Page MenuHomeSoftware Heritage
Differential D1244

[swh-web] highlightjs-line-numbers: Use a better fix for copy/paste issue with FF/Edge
ClosedPublic
Actions

Authored by anlambert on Mar 14 2019, 8:42 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS84a575d8aba3: assets/highlightjs-line-numbers: Upgrade to 2.7.0
Summary

This reverts rDWAPPSfcbbef809cdf1569276dd44c6422e0ee4e8645af in favor of a better and simpler fix.

See https://github.com/wcoder/highlightjs-line-numbers.js/pull/62 for more details.

Diff Detail

Repository
rDWAPPS Web applications
Branch
diff-hljs-ln-update
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4650
Build 6177: tox-on-jenkinsJenkins
Build 6176: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 14 2019, 8:42 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 14 2019, 8:42 PM
swh-public-ci added a subscriber: swh-public-ci.Mar 14 2019, 8:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/245/ for more details.

Harbormaster completed remote builds in B4650: Diff 3935.Mar 14 2019, 8:46 PM
anlambert edited the summary of this revision. (Show Details)Mar 14 2019, 8:51 PM
anlambert added a reverted change: rDWAPPSfcbbef809cdf: assets: Use temporarily a patched highlightjs-line-numbers library.
anlambert updated this revision to Diff 3962.Mar 15 2019, 5:42 PM

Rebase to master

swh-public-ci added a comment.Mar 15 2019, 5:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/333/ for more details.

Harbormaster completed remote builds in B4676: Diff 3962.Mar 15 2019, 5:48 PM
anlambert updated this revision to Diff 4076.Mar 25 2019, 12:12 PM

Update: https://github.com/wcoder/highlightjs-line-numbers.js/pull/62 got merged \o/ so adapt diff accordingly

swh-public-ci added a comment.Mar 25 2019, 12:15 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/347/ for more details.

Harbormaster completed remote builds in B4786: Diff 4076.Mar 25 2019, 12:15 PM
vlorentz accepted this revision.Mar 26 2019, 4:56 PM
This revision is now accepted and ready to land.Mar 26 2019, 4:56 PM
Closed by commit rDWAPPS84a575d8aba3: assets/highlightjs-line-numbers: Upgrade to 2.7.0 (authored by anlambert). · Explain WhyMar 27 2019, 12:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
web/
assets/
src/
bundles/
revision/
61 lines
thirdparty/
highlightjs-line-numbers/
198 lines
utils/
2 lines

Diff 3935

View Options

swh/web/assets/src/bundles/revision/diff-utils.js

Loading...
View Options

swh/web/assets/src/thirdparty/highlightjs-line-numbers/highlightjs-line-numbers.js

Loading...
View Options

swh/web/assets/src/utils/highlightjs.css

Loading...
About · Developer information · Legal