Differential D1141

Don't send 'None' as a revision id to storage.revision_get.
ClosedPublic
Actions

Authored by vlorentz on Feb 14 2019, 5:09 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDXd003f0b2a042: Don't send 'None' as a revision id to storage.revision_get.

Summary

This error wasn't caught before because the in-mem storage
accepts None values, but the pg storage doesn't.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

revision_get-None

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4258
Build 5622: tox-on-jenkins	Jenkins
Build 5621: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 14 2019, 5:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 14 2019, 5:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/425/ for more details.

Harbormaster completed remote builds in B4258: Diff 3608.Feb 14 2019, 5:11 PM

ardumont accepted this revision.Feb 14 2019, 5:14 PM

This revision is now accepted and ready to land.Feb 14 2019, 5:14 PM

Closed by commit rDCIDXd003f0b2a042: Don't send 'None' as a revision id to storage.revision_get. (authored by vlorentz). · Explain WhyFeb 14 2019, 5:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

metadata.py

8 lines

Diff 3608

View Options

Don't send 'None' as a revision id to storage.revision_get.ClosedPublicActions