Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- R65:33faefc34bcb: home-origin.html: fix wrong form action url
R65:28f25beae684: templates: fix wrong data-toggle attribute on elem
R65:e534bd5ab782: browse: fix redirection url generation issue
rDWAPPS28f25beae684: templates: fix wrong data-toggle attribute on elem
rDWAPPSe534bd5ab782: browse: fix redirection url generation issue
rDWAPPS33faefc34bcb: home-origin.html: fix wrong form action url
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- FixInt
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 454 Build 666: Software Heritage Python tests Build 665: arc lint + arc unit
Event Timeline
home-origin.html: fix wrong form action url
templates: fix wrong data-toggle attribute on elem
browse: fix redirection url generation issue
swh/web/ui/views/browse.py | ||
---|---|---|
37 ↗ | (On Diff #387) | Maybe send this instruction below the 'dir_path' condition code since it's unused in it. |
43 ↗ | (On Diff #387) | Why do you need to do explicitely the condition code on the variable dir_path? Adapting the existing code with the dir_path renamed was ok, i think. return redirect(url_for('browse_revision_directory', return redirect(url_for('browse_revision_directory', sha1_git=sha1_git, dir_path=data.get('dir_path'))) |
swh/web/ui/views/browse.py | ||
---|---|---|
43 ↗ | (On Diff #387) | Sorry, i mistyped. I meant, this should be enough, shouldn't it? return redirect(url_for('browse_revision_directory', sha1_git=sha1_git, dir_path=data.get('dir_path'))) |
swh/web/ui/views/browse.py | ||
---|---|---|
43 ↗ | (On Diff #387) | Empty GET params (like path) are empty strings when I receive them. This was to avoid giving an empty string to url_for, which would build an incorrect url for the redirect. It's factorized and more legible now :) |
swh/web/ui/views/browse.py | ||
---|---|---|
43 ↗ | (On Diff #387) |
Ok. I did not thought of that.
Indeed. Awesome. Thanks. |