Page MenuHomeSoftware Heritage

docs/developer-setup: Update documentation about auto-completion
ClosedPublic

Authored by ardumont on Feb 14 2019, 9:15 AM.

Details

Summary

Improving the postactivate hook example to work both for zsh/bash
users

Test Plan

After amending the postactivate hook described in the diff:

$ bash
$ workon swh
$ swh-scheduler <tab> <tab> # <- completion should work and show the scheduler's cli subcommands
$ deactivate
$ zsh
$ workon swh  # <- this no longer displays warnings/errors about completion
$ swh-scheduler <tab> <tab>  # <- completion should now work as in the bash shell

Diff Detail

Repository
rDDOC Development documentation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 14 2019, 9:15 AM
ardumont edited the test plan for this revision. (Show Details)Feb 14 2019, 9:17 AM
ardumont edited the test plan for this revision. (Show Details)
ardumont edited the test plan for this revision. (Show Details)
ardumont marked an inline comment as done.Feb 14 2019, 9:19 AM
ardumont added inline comments.
docs/developer-setup.rst
79

i did the case/esac stuff as i found it clearer than the if/else
but also as kind of yagni for the day other shells start to get supported...

ardumont updated this revision to Diff 3569.Feb 14 2019, 9:30 AM

Fix indentation (missing 4 spaces)

douardda accepted this revision.Feb 14 2019, 9:32 AM
This revision is now accepted and ready to land.Feb 14 2019, 9:32 AM
This revision was automatically updated to reflect the committed changes.