Page MenuHomeSoftware Heritage
Differential D1036

Drop 'except Exception', it catches too many errors.
ClosedPublic
Actions

Authored by vlorentz on Jan 30 2019, 11:27 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSCHb25c7cd7f4ec: Drop 'except Exception', it catches too many errors.
Summary

eg. ImportErrors when negotiate is not installed.

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
except-catchall
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3879
Build 5076: tox-on-jenkinsJenkins
Build 5075: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 30 2019, 11:27 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 30 2019, 11:27 AM
swh-public-ci added a subscriber: swh-public-ci.Jan 30 2019, 11:29 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/137/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/137/console

Harbormaster failed remote builds in B3846: Diff 3285!Jan 30 2019, 11:29 AM
swh-public-ci added a comment.Jan 30 2019, 12:21 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/139/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/139/console

ardumont accepted this revision.Jan 30 2019, 12:36 PM
This revision is now accepted and ready to land.Jan 30 2019, 12:36 PM
vlorentz updated this revision to Diff 3302.Jan 30 2019, 1:56 PM
  • rebase
Closed by commit rDSCHb25c7cd7f4ec: Drop 'except Exception', it catches too many errors. (authored by vlorentz). · Explain WhyJan 30 2019, 1:56 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B3879: Diff 3302!Jan 30 2019, 1:56 PM
swh-public-ci added a comment.Jan 30 2019, 1:56 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/141/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/141/console

Revision Contents
Changeset List

PathSize
swh/
scheduler/
2 lines

Diff 3302

View Options

swh/scheduler/cli.py

Loading...
About · Developer information · Legal