Page MenuHomeSoftware Heritage

Embed the code from the negotiate package in the sources
ClosedPublic

Authored by douardda on Tue, Jan 29, 12:07 PM.

Details

Summary

so that we do have to manage yet another dependecy; the code is small and has
not been modified for years.

Also move API related code in an swh.core.api package

closes T1499

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Tue, Jan 29, 12:07 PM
ardumont accepted this revision.Tue, Jan 29, 12:26 PM
This revision is now accepted and ready to land.Tue, Jan 29, 12:26 PM
vlorentz requested changes to this revision.Tue, Jan 29, 12:26 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/core/api/negotiate.py
1–3 ↗(On Diff #3240)

The full license text should be included here ("The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.")

Also don't forget to update debian/copyright in the appropriate branch.

This revision now requires changes to proceed.Tue, Jan 29, 12:26 PM

swh/core/api_async.py is used by the vault.

swh/core/api_async.py is used by the vault.

yes, and it will still work with the change here.

yes, and it will still work with the change here.

Oh, I missed the new import *. Nevermind then.

swh/core/api/__init__.py
28–45

Should be in negotiate.py (it makes sense logically, and it will get the required copyright notice.)

douardda updated this revision to Diff 3246.Tue, Jan 29, 1:39 PM

Insert the MIT license in the negotiate.py file

douardda marked an inline comment as done.Tue, Jan 29, 1:40 PM
douardda added inline comments.
swh/core/api/negotiate.py
1–3 ↗(On Diff #3240)
ardumont accepted this revision.Tue, Jan 29, 2:59 PM
vlorentz accepted this revision.Wed, Jan 30, 12:27 PM
This revision is now accepted and ready to land.Wed, Jan 30, 12:27 PM
This revision was automatically updated to reflect the committed changes.