Page MenuHomeSoftware Heritage
Differential D1012

swh-web/config: Allow to enable/disable reCAPTCHA integration
ClosedPublic
Actions

Authored by anlambert on Jan 25 2019, 7:10 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
R65:13d028495807: config: Add a new key to enable/disable recaptcha integration
rDWAPPS13d028495807: config: Add a new key to enable/disable recaptcha integration
Summary

Save code now forms are currently protected by reCAPTCHA to prevent bots.

While this is important for production, it is quite cumbersome for local
development. So allow to disable the use of reCAPTCHA through the new
configuration entry grecaptcha.activated.

Related T1496

Test Plan

Tests have been added for that new feature.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 25 2019, 7:10 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 25 2019, 7:10 PM
anlambert updated this revision to Diff 3207.Jan 25 2019, 7:11 PM

Update: Fix typo in commit log

anlambert edited the summary of this revision. (Show Details)Jan 25 2019, 7:13 PM
swh-public-ci added a subscriber: swh-public-ci.Jan 25 2019, 7:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/113/ for more details.

Harbormaster completed remote builds in B3742: Diff 3206.Jan 25 2019, 7:13 PM
swh-public-ci added a comment.Jan 25 2019, 7:17 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/115/ for more details.

Harbormaster completed remote builds in B3743: Diff 3207.Jan 25 2019, 7:17 PM
anlambert added a child revision: D1013: swh-site: Force recaptcha activation in swh-web configuration.Jan 25 2019, 7:21 PM
anlambert added a child revision: D1014: docker/swh-web: Disable recaptcha integration.Jan 25 2019, 7:42 PM
vlorentz accepted this revision.Jan 26 2019, 10:47 PM
vlorentz added a subscriber: vlorentz.

And it fixes the issue of including Google's JS on pages that don't need it :)

This revision is now accepted and ready to land.Jan 26 2019, 10:47 PM
Closed by commit rDWAPPS13d028495807: config: Add a new key to enable/disable recaptcha integration (authored by anlambert). · Explain WhyJan 28 2019, 11:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
web/
assets/
src/
bundles/
browse/
13 lines
webapp/
10 lines
browse/
views/
2 lines
common/
23 lines
1 line
templates/
browse/
1 line
36 lines
includes/
33 lines
1 line
tests/
browse/
views/
143 lines

Diff 3213

View Options

swh/web/assets/src/bundles/browse/origin-save.js

Loading...
View Options

swh/web/assets/src/bundles/webapp/webapp-utils.js

Loading...
View Options

swh/web/browse/views/origin_save.py

Loading...
View Options

swh/web/common/utils.py

Loading...
View Options

swh/web/config.py

Loading...
View Options

swh/web/templates/browse/layout.html

Loading...
View Options

swh/web/templates/browse/origin-save.html

Loading...
View Options

swh/web/templates/includes/take-new-snapshot.html

Loading...
View Options

swh/web/templates/layout.html

Loading...
View Options

swh/web/tests/browse/views/test_origin_save.py

Loading...
About · Developer information · Legal