HomeSoftware Heritage

(IAC-1228) Remove '+' from shell_join_spec test data

Description

(IAC-1228) Remove '+' from shell_join_spec test data

Prior to this commit, the spec/functions/shell_join_spec.rb tests
were failing on Ruby 2.7 as the Shellwords.shelljoin method in
2.7 does not escape the + character.

Rather than have specific datasets for Ruby versions < 2.7 and
>= 2.7, it seemed easiest to simply remove this character from
the tests.

Details

Provenance
Ciaran McCrisken <ciaran.mccrisken@puppet.com>Authored on Feb 5 2021, 2:03 PM
olasdPushed on Dec 28 2021, 10:47 AM
Parents
rSPSTD57b339a17dd1: Merge pull request #1159 from puppetlabs/release
Branches
Unknown
Tags
Unknown

Event Timeline

Ciaran McCrisken <ciaran.mccrisken@puppet.com> committed rSPSTDb4605c2bbbc7: (IAC-1228) Remove '+' from shell_join_spec test data (authored by Ciaran McCrisken <ciaran.mccrisken@puppet.com>).Feb 5 2021, 4:57 PM