HomeSoftware Heritage

Fixes #26199 - Fix dependency cycle when using git_repo
9e250b70ac19Unpublished

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.

Description

Fixes #26199 - Fix dependency cycle when using git_repo

Previously this resulted in a dependency cycle. The tests didn't compile
so didn't catch it.

dependency cycles found: (File[/opt/puppetlabs/puppet/cache] => Class[Puppet::Server::Install] => Class[Puppet::Server::Config] => File[/opt/puppetlabs/puppet] => File[/opt/puppetlabs/puppet/cache])

a61e010e8d24f2e44ab1ebba0cc4382b05ce9d37 introduced this by managing
$sharedir in puppet::server::config. $vardir was managed in
puppet::server::install. Since sharedir is actually
/opt/puppetlabs/puppet and vardir is the cache directory within that, it
created a cycle.

(cherry picked from commit 964f110cdb8e654572b96553607e0784674d2a8e)

Details

Provenance
Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>Authored on Mar 1 2019, 12:21 AM
olasdPushed on Jun 26 2019, 2:00 PM
Parents
rSPPUPa541d70e47b6: Fix for Windows agent restart loop by setting file mode
Branches
Unknown
Tags
Unknown

Event Timeline

Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl> committed rSPPUP9e250b70ac19: Fixes #26199 - Fix dependency cycle when using git_repo (authored by Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>).Apr 2 2019, 7:16 PM