HomeSoftware Heritage

Allow order parameter to be string value (#893)

Description

Allow order parameter to be string value (#893)

  • Allow order parameter to be string value

concat::fragment accepts either a string or integer as order parameter value.
Numeric ordering doesn't work once converted to string filenames:

20 sequential fragments for example

Numeric (no padding)String (0 Zero Padded)
10_fragment001_fragment
11_fragment002_fragment
...
19_fragment010_fragment
1_fragment011_fragment
20_fragment012_fragment
2_fragment013_fragment
3_fragment014_fragment

Order has gone to pot...

  • Allow order parameter to be string value

concat::fragment accepts either a string or integer as order parameter value.
Numeric ordering doesn't work once converted to string filenames:

20 sequential fragments for example

Numeric (no padding)String (0 Zero Padded)
10_fragment001_fragment
11_fragment002_fragment
...
19_fragment010_fragment
1_fragment011_fragment
20_fragment012_fragment
2_fragment013_fragment
3_fragment014_fragment

Order has gone to pot...

@derbious

adding rspec tests to check manage_pg_hba_conf w/ acls
removing unneeded test

Details

Provenance
Brett Maton <matonb@ltresources.co.uk>Authored on Jul 11 2017, 10:29 AM
Helen <helen@puppetlabs.com>Committed on Jul 11 2017, 10:29 AM
olasdPushed on Sep 12 2017, 2:54 PM
Parents
rSPPGc09891786d41: Merge pull request #895 from puppetlabs/msync_modules5187
Branches
Unknown
Tags
Unknown

Event Timeline

Helen <helen@puppetlabs.com> committed rSPPG442853d1beb6: Allow order parameter to be string value (#893) (authored by Brett Maton <matonb@ltresources.co.uk>).Jul 11 2017, 10:29 AM