HomeSoftware Heritage

Change default 'order' parameter to be a string Under Puppet 3.5.1 (and…
cd645a836006Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Change default 'order' parameter to be a string Under Puppet 3.5.1 (and possibly earlier versions, too), the validate_string($order) fails when $order is actaully a numeric type. Apparently there is more strict type checking now. Can't just change validate_string to a is_numeric check, because it's fairly common to use strings like '01' for the order parameter, which doesn't pass the is_numeric test. Additionally, there is nothing saying that $order must be a number. Ultimately the ordering gets implemented as filesystem directory list sorting.

Details

Provenance
Mike Dorman <mdorman@godaddy.com>Authored on
olasdPushed on Sep 10 2015, 1:22 PM
Parents
rSPCAT7ede29bd8edb: Merge pull request #175 from apenney/fix-1404
Branches
Unknown
Tags
Unknown

Event Timeline