HomeSoftware Heritage

Fix apt_has_updates fact not parsing apt-check output correctly
e7fee16589fcUnpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

Fix apt_has_updates fact not parsing apt-check output correctly

The /usr/lib/update-notifier/apt-check script returns its output
to STDERR but a recent change to the script redirects STDERR to
/dev/null. This will cause the array to always be empty.

Combined with that problem, while we were checking for the result
being nil, we never checked for an invalid array. As a result,
the apt_has_updates was always true and the apt_updates and
apt_security_updates facts were trying to read from an empty array
and failing.

Details

Provenance
WolverineFan <github@uni-nets.com>Authored on
olasdPushed on Sep 23 2015, 3:15 PM
Parents
rSPAPT6d60659e7032: Merge pull request #409 from cyberious/MOD1661
Branches
Unknown
Tags
Unknown

Event Timeline

WolverineFan <github@uni-nets.com> committed rSPAPTe7fee16589fc: Fix apt_has_updates fact not parsing apt-check output correctly (authored by WolverineFan <github@uni-nets.com>).Jan 16 2015, 11:45 PM