HomeSoftware Heritage

origin_visit_add: Adapt endpoint signature to return OriginVisit

Description

origin_visit_add: Adapt endpoint signature to return OriginVisit

Prior to this commit, there was:

  • no signature in the method
  • discrepancy between checks on the different backend

origin_visit_add endpoint is now typed

def origin_visit_add(
    self, origin_url: str,
    date: Union[str, datetime.datetime], type: str) -> OriginVisit:

This also:

  • renames appropriately the origin_url parameter (removing 1 FIXME)
  • align backend implementations' check which were different

Details

Provenance
ardumontAuthored on Mar 12 2020, 7:54 PM
ardumontPushed on Mar 13 2020, 2:16 PM
Differential Revision
D2820: storage: origin_visit_add: Type and make origin_visit_add return an OriginVisit object
Parents
rDSTO0456cce5a0d4: origin_visit_upsert: Use OriginVisit object as input
Branches
Unknown
Tags
Unknown
References
tag: v0.0.178
Build Status
Buildable 11118
Build 16766: test-and-buildJenkins