HomeSoftware Heritage

pgstorage: Empty temp tables instead of dropping them

Authored by ardumont on Jan 24 2020, 11:57 AM.

Description

pgstorage: Empty temp tables instead of dropping them

Due to our pattern of adding objects [1], vacuum is triggered regularly on
pg_catalog.*, having an heavy impact on performance.

This commit tries to avoid the dropping the temporary tables part, emptying
them instead (they still are dropped at the end of the session but less often).
This should decrease the bloat on pg_catalog.* tables.

[1]

  • create temporary table
  • insert data from temporary table to production table with filtering
  • drop temporary table

Details

Committed
ardumontJan 24 2020, 12:14 PM
Pushed
ardumontJan 24 2020, 2:38 PM
Differential Revision
D2580: pgstorage: Empty temp tables instead of dropping them
Parents
rDSTOcc2581008a7d: assert list doesn't have too many values
Branches
Unknown
Tags
Unknown
Build Status
Buildable 10273
Build 15249: test-and-buildJenkins