HomeSoftware Heritage

opam: Move the state initialization into the get_pages method

Description

opam: Move the state initialization into the get_pages method

We should avoid side-effects in the constructor as much as possible. That avoids
surprising behavior at object instantiation time. The state if needed must be
initialized into the swh.lister.pattern.Lister.get_pages method, as preconized in the
class docstring.

This also fixes the current test that actually bootstrap a real opam local "clone" in
/tmp.

Related to T3590

Details

Provenance
ardumontAuthored on Sep 20 2021, 5:41 PM
ardumontPushed on Sep 21 2021, 11:23 AM
Differential Revision
D6310: opam: Move the state initialization into the get_pages method
Parents
rDLSc803fc2b5908: Allow gitlab lister's name to be overriden by task arguments
Branches
Unknown
Tags
Unknown
Build Status
Buildable 23855
Build 37203: test-and-buildJenkins console · Jenkins