HomeSoftware Heritage

Don't assume all GitClient instances have a 'dumb' attribute

Description

Don't assume all GitClient instances have a 'dumb' attribute

Only instances of (subclasses of) AbstractHttpGitClient have this attribute.

For other instances, we can consider it to be False, because the dumb
protocol only exists over HTTP(S).

This issue was found by mypy, thanks to the addition of type annotations
to changes in dulwich 0.20.36 affecting mypy's type inference.

Details

Provenance
vlorentzAuthored on May 16 2022, 2:41 PM
vlorentzPushed on May 16 2022, 3:23 PM
Differential Revision
D7835: Don't assume all GitClient instances have a 'dumb' attribute
Parents
rDLDG9b47b24b98c2: Use all base snapshots in determine_wants()
Branches
Unknown
Tags
Unknown
Build Status
Buildable 29407
Build 45957: test-and-buildJenkins console · Jenkins