Diffusion Generic VCS/Package Loader 43597c480640

Initialize 'status' before try block
43597c480640
Actions

Description

Initialize 'status' before try block

It seems that despite setting it in the 'except BaseException' block,
it is still occasionally undefined in the 'finally' block when
triggered by a SystemExit exception.

This should hopefully prevent UnboundLocalError from
being raised from the 'finally' block from now on

Details

Provenance

vlorentz	Authored on Aug 8 2022, 10:32 AM
vlorentz	Pushed on Aug 8 2022, 2:33 PM

Differential Revision

D8207: Initialize 'status' before try block

Parents

rDLDBASE0913e11f6991: docs: Mention caveats of using archive checksums as ExtID.

Branches

Unknown

Tags

Unknown

Tasks

Restricted Maniphest Task

Build Status

Buildable 30682
Build 47975: test-and-build	Jenkins console · Jenkins

Event Timeline

vlorentz committed rDLDBASE43597c480640: Initialize 'status' before try block (authored by vlorentz).Aug 8 2022, 10:32 AM

vlorentz added a task: Restricted Maniphest Task.Aug 8 2022, 2:33 PM

vlorentz added an edge: D8207: Initialize 'status' before try block.

Harbormaster completed building B30682: rDLDBASE43597c480640: Initialize 'status' before try block.Aug 8 2022, 2:37 PM

swh-public-ci mentioned this in D8171: crates: Loader implements incremental mode.Aug 9 2022, 8:39 AM

swh-public-ci mentioned this in D8174: Aur: Implements basic loader.Aug 10 2022, 5:03 PM

swh-public-ci mentioned this in D8264: Arch: Adapt the loader to manage 'arch_metadata' from 'extra_loader_arguments'.Aug 19 2022, 12:09 PM

Changes (1)

Path

Size

swh/

loader/

core/

loader.py

rDLDBASE43597c480640

View Options