HomeSoftware Heritage

Remove 'journal_type' argument from the CLI

Description

Remove 'journal_type' argument from the CLI

Motivation:

  • This simplifies the CLI, and stops leaking implementation details (what field the implementation reads, what keys contains, that keys exist at all, etc.) through this interface.
  • It also removes the need to have two clients, both reading revisions and releases.

This preserves the optimization of not deserializing unneeded values,
by passing raw message values to the worker functions; which can
deserialize it themselves if needed.

Additionally, this commit fixes some mistakes in type annotations.

Details

Provenance
vlorentzAuthored on Apr 22 2021, 4:28 PM
vlorentzPushed on Apr 22 2021, 8:21 PM
Differential Revision
D5576: Remove 'journal_type' argument from the CLI
Parents
rDCNT5cae9b7cfe30: Implement the jounal client counting an internal property of an object
Branches
Unknown
Tags
Unknown
References
tag: v0.7.0
Build Status
Buildable 20946
Build 32506: test-and-buildJenkins console · Jenkins