Differential D8980

Add support to return simple lists without pagination
ClosedPublic
Actions

Authored by jayeshv on Dec 23 2022, 4:35 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Commits

rDGQL419b84136682: Add support to return simple lists without pagination

Summary

Some connections do not require pagination support
eg: ResolveSWHID, that returns a list but is alwasys too small
for any real pagination. Add a BaseList class to support such items.

Diff Detail

Repository

rDGQL GraphQL API

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jayeshv created this revision.Dec 23 2022, 4:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 23 2022, 4:35 PM

Build is green

Patch application report for D8980 (id=32357)

Rebasing onto 5446d4f87f...

Current branch diff-target is up to date.

Changes applied before test

commit a9191369f8952b7fe329f37dfa8ea2b0a891a1f4
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 16:28:10 2022 +0100

    Add support to return simple lists without pagination
    
    Some connections do not require pagination support
    eg: ResolveSWHID, that returns a list but is alwasys too small
    for any real pagination. Add a BaseList class to support such items.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/266/ for more details.

Harbormaster completed remote builds in B33343: Diff 32357.Dec 23 2022, 4:37 PM

jayeshv requested review of this revision.Dec 23 2022, 4:37 PM

jayeshv mentioned this in D8979: Add missing default arguments to resolveSWHID entrypoint.Dec 23 2022, 4:38 PM

typo

Build is green

Patch application report for D8980 (id=32358)

Rebasing onto 5446d4f87f...

Current branch diff-target is up to date.

Changes applied before test

commit 419b8413668240d95da96a0e25e234b612d1890f
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 16:28:10 2022 +0100

    Add support to return simple lists without pagination
    
    Some connections do not require pagination support
    eg: ResolveSWHID, that returns a list but is alwasys too small
    for any real pagination. Add a BaseList class to support such items.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/267/ for more details.

Harbormaster completed remote builds in B33344: Diff 32358.Dec 23 2022, 4:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 23 2022, 6:13 PM

Closed by commit rDGQL419b84136682: Add support to return simple lists without pagination (authored by jayeshv). · Explain Why

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL419b84136682: Add support to return simple lists without pagination.