Page MenuHomeSoftware Heritage
Feed Advanced Search

Aug 26 2022

franckbret committed rDLDBASE6a43542ed982: Change name of task method (authored by franckbret).
Change name of task method
Aug 26 2022, 3:16 PM
franckbret requested review of D8321: Pubdev, Change name of task method.
Aug 26 2022, 3:13 PM
franckbret closed D8305: PubDev, loads from pub.dev registry (Dart, Flutter).
Aug 26 2022, 10:31 AM
franckbret committed rDLDBASEaa26fbd98ef8: PubDev, loads from pub.dev registry (Dart, FLutter) (authored by franckbret).
PubDev, loads from pub.dev registry (Dart, FLutter)
Aug 26 2022, 10:31 AM
franckbret closed D8287: Pub.dev lister for Dart and Flutter packages.
Aug 26 2022, 10:30 AM
franckbret committed rDLS5410b6e3f38a: Pub.dev lister for Dart and Flutter packages (authored by franckbret).
Pub.dev lister for Dart and Flutter packages
Aug 26 2022, 10:30 AM
franckbret updated the diff for D8287: Pub.dev lister for Dart and Flutter packages.

Rebase

Aug 26 2022, 10:24 AM
franckbret updated the diff for D8305: PubDev, loads from pub.dev registry (Dart, Flutter).

Add a fake_pubdev.sh script that generate fake http api response and fake package archives for test purpose

Aug 26 2022, 9:17 AM

Aug 25 2022

franckbret added a comment to D8305: PubDev, loads from pub.dev registry (Dart, Flutter).

Thanks, looks good.

One last thing: could you find smaller alternative for the test files? These are quite big, especially packages_pdf_versions_3.8.2.tar.gz

Aug 25 2022, 4:22 PM
franckbret updated the diff for D8305: PubDev, loads from pub.dev registry (Dart, Flutter).

Remove filename from release name

Aug 25 2022, 3:42 PM
franckbret updated the diff for D8287: Pub.dev lister for Dart and Flutter packages.

Add documentation

Aug 25 2022, 2:09 PM
franckbret updated the diff for D8305: PubDev, loads from pub.dev registry (Dart, Flutter).

Add pubdev entry to package loader specifications documentation

Aug 25 2022, 12:25 PM
franckbret updated the diff for D8305: PubDev, loads from pub.dev registry (Dart, Flutter).

Testing authors and empty author

Aug 25 2022, 12:13 PM

Aug 24 2022

franckbret retitled D8305: PubDev, loads from pub.dev registry (Dart, Flutter) from [WIP] PubDev, loads from pub.dev registry (Dart, Flutter) to PubDev, loads from pub.dev registry (Dart, Flutter).
Aug 24 2022, 5:09 PM
franckbret added inline comments to D8305: PubDev, loads from pub.dev registry (Dart, Flutter).
Aug 24 2022, 5:09 PM
franckbret updated the diff for D8305: PubDev, loads from pub.dev registry (Dart, Flutter).

Some improvments after review

Aug 24 2022, 5:05 PM
franckbret retitled D8287: Pub.dev lister for Dart and Flutter packages from [WIP] Pub.dev lister for Dart and Flutter packages to Pub.dev lister for Dart and Flutter packages.
Aug 24 2022, 4:43 PM
franckbret updated the diff for D8287: Pub.dev lister for Dart and Flutter packages.

Some improvments after review

Aug 24 2022, 4:18 PM
franckbret requested review of D8305: PubDev, loads from pub.dev registry (Dart, Flutter).
Aug 24 2022, 1:34 PM

Aug 23 2022

franckbret updated the diff for D8287: Pub.dev lister for Dart and Flutter packages.

Remove package versions data from lister.

Aug 23 2022, 3:24 PM
franckbret added a comment to D8287: Pub.dev lister for Dart and Flutter packages.

Hey,

If I understand this correctly:

  1. get_pages() first gets a list of packages, then
  2. get_pages() fetches all these pages, then
  3. get_origins_from_page() creates an origin for each page with the list of versions, with a list of version of that package

Given that the lister's job is only to discover a list of origins, I think the lister should only do step 1 and create a ListedOrigin.
The loader should then fetch the list of versions of each package, which is part of its job.

The only reason some listers fetch the list of versions is that it would not be otherwise available to loaders, but that is not true here, so we should avoid it.

This keeps the architecture closer to what we want to do, and avoids bloating the scheduler database with (potentially long) lists of releases in each row.

Aug 23 2022, 2:52 PM
franckbret requested review of D8287: Pub.dev lister for Dart and Flutter packages.
Aug 23 2022, 10:50 AM

Aug 19 2022

franckbret closed D8264: Arch: Adapt the loader to manage 'arch_metadata' from 'extra_loader_arguments'.
Aug 19 2022, 3:55 PM
franckbret committed rDLDBASE9f8bdceed14a: Arch: Adapt the loader to manage 'arch_metadata' from 'extra_loader_arguments' (authored by franckbret).
Arch: Adapt the loader to manage 'arch_metadata' from 'extra_loader_arguments'
Aug 19 2022, 3:54 PM
franckbret closed D8259: arch: Extra_loader_arguments consistency.
Aug 19 2022, 3:53 PM
franckbret committed rDLS7dd412e5538d: arch: Extra_loader_arguments consistency + documentation (authored by franckbret).
arch: Extra_loader_arguments consistency + documentation
Aug 19 2022, 3:53 PM
franckbret updated the diff for D8259: arch: Extra_loader_arguments consistency.

Rebase

Aug 19 2022, 3:47 PM
franckbret updated the diff for D8264: Arch: Adapt the loader to manage 'arch_metadata' from 'extra_loader_arguments'.

Rebase

Aug 19 2022, 1:10 PM
franckbret updated subscribers of D8264: Arch: Adapt the loader to manage 'arch_metadata' from 'extra_loader_arguments'.

ask @vlorentz for review

Aug 19 2022, 1:07 PM
franckbret updated the diff for D8259: arch: Extra_loader_arguments consistency.

Rebase

Aug 19 2022, 1:01 PM
franckbret closed D8174: Aur: Implements basic loader.
Aug 19 2022, 12:55 PM
franckbret committed rDLDBASE9493891b4888: Aur: Implements basic loader (authored by franckbret).
Aur: Implements basic loader
Aug 19 2022, 12:55 PM
franckbret closed D8033: Arch User Repository (AUR) lister.
Aug 19 2022, 12:51 PM
franckbret committed rDLS97b353bf0b9a: Arch User Repository (AUR) lister (authored by franckbret).
Arch User Repository (AUR) lister
Aug 19 2022, 12:51 PM
franckbret updated the diff for D8174: Aur: Implements basic loader.

Rebase on master

Aug 19 2022, 12:49 PM
franckbret updated the diff for D8033: Arch User Repository (AUR) lister.

Rebase on master

Aug 19 2022, 12:45 PM
franckbret updated the diff for D8264: Arch: Adapt the loader to manage 'arch_metadata' from 'extra_loader_arguments'.

Adapt package loader specifications

Aug 19 2022, 12:31 PM
franckbret requested review of D8264: Arch: Adapt the loader to manage 'arch_metadata' from 'extra_loader_arguments'.
Aug 19 2022, 12:20 PM
franckbret added a comment to D8259: arch: Extra_loader_arguments consistency.

Add documentation

Aug 19 2022, 11:21 AM
franckbret updated the diff for D8259: arch: Extra_loader_arguments consistency.

Add documentation

Aug 19 2022, 11:10 AM
franckbret requested review of D8259: arch: Extra_loader_arguments consistency.
Aug 19 2022, 6:43 AM

Aug 18 2022

franckbret added a comment to D8033: Arch User Repository (AUR) lister.

Can we merge this one?

Aug 18 2022, 4:05 PM
franckbret updated the diff for D8174: Aur: Implements basic loader.

Add a test that check various packages names and versions with different syntax

Aug 18 2022, 4:02 PM
franckbret added inline comments to D8174: Aur: Implements basic loader.
Aug 18 2022, 3:17 PM
franckbret added inline comments to D8174: Aur: Implements basic loader.
Aug 18 2022, 12:40 PM
franckbret added inline comments to D8174: Aur: Implements basic loader.
Aug 18 2022, 12:38 PM
franckbret updated the diff for D8174: Aur: Implements basic loader.

Add aur entry to package loader specifications documentation

Aug 18 2022, 12:17 PM

Aug 17 2022

franckbret updated the diff for D8174: Aur: Implements basic loader.

Split artifacts to artifacts and aur_metadata.

Aug 17 2022, 8:08 PM
franckbret added inline comments to D8033: Arch User Repository (AUR) lister.
Aug 17 2022, 12:01 PM
franckbret updated the diff for D8033: Arch User Repository (AUR) lister.

Rephrase the documentation part about regular and split packages

Aug 17 2022, 11:53 AM

Aug 16 2022

franckbret updated the diff for D8033: Arch User Repository (AUR) lister.

Fix docstrings errors

Aug 16 2022, 7:11 PM
franckbret updated the diff for D8033: Arch User Repository (AUR) lister.

Fix documentation build

Aug 16 2022, 6:12 PM
franckbret updated the diff for D8033: Arch User Repository (AUR) lister.

Document the module

Aug 16 2022, 5:28 PM
franckbret updated the diff for D8033: Arch User Repository (AUR) lister.

Add a directory cleanup test

Aug 16 2022, 3:30 PM
franckbret updated the diff for D8033: Arch User Repository (AUR) lister.

Add a finalize method that remove temporary directory once the lister complete

Aug 16 2022, 12:43 PM
franckbret updated the diff for D8033: Arch User Repository (AUR) lister.

Split artifacts data to artifacts and aur_metadata

Aug 16 2022, 12:33 PM

Aug 11 2022

franckbret added inline comments to D8174: Aur: Implements basic loader.
Aug 11 2022, 3:39 PM
franckbret added inline comments to D8174: Aur: Implements basic loader.
Aug 11 2022, 1:31 PM

Aug 10 2022

franckbret added inline comments to D8174: Aur: Implements basic loader.
Aug 10 2022, 5:05 PM
franckbret retitled D8174: Aur: Implements basic loader from WIP: Aur: Implements basic loader to Aur: Implements basic loader.
Aug 10 2022, 5:02 PM
franckbret added inline comments to D8174: Aur: Implements basic loader.
Aug 10 2022, 5:02 PM
franckbret updated the diff for D8174: Aur: Implements basic loader.

Some improvments after code review

Aug 10 2022, 5:00 PM
franckbret added inline comments to D8171: crates: Loader implements incremental mode.
Aug 10 2022, 12:28 PM
franckbret added inline comments to D8171: crates: Loader implements incremental mode.
Aug 10 2022, 11:35 AM

Aug 9 2022

franckbret added inline comments to D8171: crates: Loader implements incremental mode.
Aug 9 2022, 3:13 PM
franckbret updated the diff for D8171: crates: Loader implements incremental mode.

Fix typos in docstrings

Aug 9 2022, 2:23 PM
franckbret updated the diff for D8171: crates: Loader implements incremental mode.

Change EXTID_TYPE name and MANIFEST_FORMAT

Aug 9 2022, 1:25 PM
franckbret added inline comments to D8171: crates: Loader implements incremental mode.
Aug 9 2022, 11:30 AM
franckbret added inline comments to D8171: crates: Loader implements incremental mode.
Aug 9 2022, 10:47 AM
franckbret updated the diff for D8171: crates: Loader implements incremental mode.

Add 'yanked' information to PackageInfo and adapt tests

Aug 9 2022, 10:05 AM
franckbret updated the diff for D8171: crates: Loader implements incremental mode.

Remove http api fixtures from tests data
Adapt fake_crates.sh script accordingly

Aug 9 2022, 9:00 AM
franckbret added a comment to D8171: crates: Loader implements incremental mode.

Switch to manifest for EXTID generation
Remove useless http api call to get the release date

Aug 9 2022, 8:54 AM
franckbret updated the diff for D8171: crates: Loader implements incremental mode.

Switch to manifest for EXTID generation
Remove useless http api call to get the release date

Aug 9 2022, 8:35 AM

Aug 8 2022

franckbret added inline comments to D8171: crates: Loader implements incremental mode.
Aug 8 2022, 4:41 PM
franckbret added a comment to D8171: crates: Loader implements incremental mode.

Hello, was there a discussion leading to this implementation? If so, it'd be nice to mention it in the description (please).

Nope

Aug 8 2022, 4:07 PM
franckbret abandoned D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.

Abandonning this one as the same content has been moved to crates lister module docstring ( see D8206 )

Aug 8 2022, 3:24 PM
franckbret closed D8206: crates: Add a developer documentation at module level.
Aug 8 2022, 3:09 PM
franckbret committed rDLS751c3df1b7aa: crates: Add a developer documentation at module level (authored by franckbret).
crates: Add a developer documentation at module level
Aug 8 2022, 3:09 PM
franckbret updated the diff for D8206: crates: Add a developer documentation at module level.

Module docstrings need to be the first statement of the file

Aug 8 2022, 2:50 PM
franckbret added inline comments to D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.
Aug 8 2022, 10:24 AM
franckbret requested review of D8206: crates: Add a developer documentation at module level.
Aug 8 2022, 10:22 AM
franckbret added inline comments to D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.
Aug 8 2022, 8:38 AM

Aug 5 2022

franckbret added inline comments to D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.
Aug 5 2022, 4:44 PM
franckbret updated the diff for D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.

Fix hyperlink, only the reference to named anchor is needed

Aug 5 2022, 4:31 PM
franckbret added inline comments to D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.
Aug 5 2022, 4:21 PM
franckbret updated the diff for D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.

Try again to fix the internal hyperlink to a section, this time replace \# with \:

Aug 5 2022, 4:07 PM
franckbret updated the diff for D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.

Try to fix internal ref link

Aug 5 2022, 3:46 PM
franckbret updated the diff for D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.

Some more typos, replace a link with an internal ref

Aug 5 2022, 3:27 PM
franckbret requested review of D8199: Add a 'user' documentation entry for the Crates lister. Add myself as contributor.
Aug 5 2022, 2:59 PM
franckbret closed D8101: crates.lister: Implement incremental mode.
Aug 5 2022, 2:03 PM
franckbret committed rDLSa6f796b26867: crates.lister: Implement incremental mode: (authored by franckbret).
crates.lister: Implement incremental mode:
Aug 5 2022, 2:03 PM
franckbret updated the diff for D8101: crates.lister: Implement incremental mode.

Rebase

Aug 5 2022, 1:44 PM
franckbret added inline comments to D8101: crates.lister: Implement incremental mode.
Aug 5 2022, 12:04 PM
franckbret updated the diff for D8101: crates.lister: Implement incremental mode.

Fix some typos
Rename 'metadata' dict to 'crates_metadata'

Aug 5 2022, 12:04 PM

Aug 3 2022

franckbret requested review of D8174: Aur: Implements basic loader.
Aug 3 2022, 4:30 PM

Aug 2 2022

franckbret updated subscribers of D8171: crates: Loader implements incremental mode.

@vlorentz @ardumont Here is a proposal to make the crates loader incremental.

Aug 2 2022, 9:37 AM
franckbret requested review of D8171: crates: Loader implements incremental mode.
Aug 2 2022, 9:35 AM

Aug 1 2022

franckbret updated the diff for D8101: crates.lister: Implement incremental mode.

Move 'yanked' information from 'artifacts' to 'metadata''
Add some more repository related debug logging

Aug 1 2022, 10:34 AM
franckbret added a comment to D8101: crates.lister: Implement incremental mode.

Don't forget these:

  • Where is last_update used? I don't see it in the artifacts list in the tests
  • Finally, could you reword your commit message to be in the imperative mood and mention it is the crates lister? eg. crates: Implement incremental listing

(and this diff's title too, to be consistent with the commit title)

Add 'yanked' to artifacts data

'yanked' is a flag used to determine if a package version has been unreleased

That's not the right place; this format is meant to describe tarballs: https://docs.softwareheritage.org/devel/swh-storage/extrinsic-metadata-specification.html#original-artifacts-json
but the "yanked" status comes from higher-level objects.

Aug 1 2022, 10:03 AM

Jul 27 2022

franckbret added a comment to D8101: crates.lister: Implement incremental mode.

@vlorentz @ardumont Are you ok with this one, can I push?

Jul 27 2022, 10:32 AM