Page MenuHomeSoftware Heritage
Differential D2760

swh.indexer.storage: Add metrics to add/del endpoints
ClosedPublic
Actions

Authored by ardumont on Mar 3 2020, 4:19 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Summary

Depends on D2759

Test Plan

tox

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10892
Build 16378: tox-on-jenkinsJenkins
Build 16377: arc lint + arc unit

Event Timeline

ardumont created this revision.Mar 3 2020, 4:19 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 3 2020, 4:19 PM
ardumont added a child revision: D2761: Make indexers return a summary of their actions.Mar 3 2020, 4:21 PM
swh-public-ci added a comment.Mar 3 2020, 4:22 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/702/ for more details.

Harbormaster completed remote builds in B10882: Diff 9823.Mar 3 2020, 4:22 PM
ardumont added inline comments.Mar 3 2020, 4:27 PM
swh/indexer/storage/metrics.py
7

Find a way to move this module up (to swh.core for example).
This is taken directly from swh.storage.metrics and slightly adapted.

vlorentz added a subscriber: vlorentz.Mar 3 2020, 4:29 PM

If each method needs to call statsd, what are the returns for?

vlorentz requested changes to this revision.Mar 3 2020, 4:30 PM
vlorentz added inline comments.
swh/indexer/storage/metrics.py
67–79

This isn't used

This revision now requires changes to proceed.Mar 3 2020, 4:30 PM
ardumont added a comment.Mar 3 2020, 5:12 PM
In D2760#65820, @vlorentz wrote:

If each method needs to call statsd, what are the returns for?

D2761 ;)

ardumont updated this revision to Diff 9831.Mar 3 2020, 7:56 PM
  • Rebase
  • Add missing @timed @process_metric decorator
swh-public-ci added a comment.Mar 3 2020, 7:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/706/ for more details.

Harbormaster completed remote builds in B10889: Diff 9831.Mar 3 2020, 7:58 PM
ardumont updated this revision to Diff 9834.Mar 3 2020, 7:58 PM

Fix commit range :/

swh-public-ci added a comment.Mar 3 2020, 8:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/709/ for more details.

Harbormaster completed remote builds in B10892: Diff 9834.Mar 3 2020, 8:02 PM
vlorentz accepted this revision.Mar 3 2020, 8:07 PM
This revision is now accepted and ready to land.Mar 3 2020, 8:07 PM
ardumont closed this revision.Mar 4 2020, 11:25 AM

Landed in f0193e78c69a4508c2bd4529d9beed2b3c7a3f91

Revision Contents
Changeset List

PathSize
swh/
indexer/
storage/
33 lines
79 lines
tests/
storage/
53 lines

Diff 9834

View Options

swh/indexer/storage/__init__.py

Loading...
View Options

swh/indexer/storage/metrics.py

Loading...
View Options

swh/indexer/tests/storage/test_metrics.py

Loading...
About · Developer information · Legal