It will be useful to loaders, as they currently load the entire
content in memory before deciding to skip it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- max-content-length
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10712 Build 16069: tox-on-jenkins Jenkins Build 16068: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/176/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/177/ for more details.
Comment Actions
Some docstrings need to be updated, my other comments are just nitpicks
| swh/model/from_disk.py | ||
|---|---|---|
| 111 | documentation for the max_content_length parameter is missing | |
| 116 | Alternative way to make flake8 happy without using a backslash too_large = (max_content_length is not None and length > max_content_length) | |
| 263 | same here | |
| swh/model/tests/test_from_disk.py | ||
| 556 | You could write: assert 'too large' in limited_content.data['reason'] to make flake8 happy and remove the backslash use. | |
| swh/model/tests/test_from_disk.py | ||
|---|---|---|
| 556 | I prefer an exact match unless there's a reason not to. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/180/ for more details.