Page MenuHomeSoftware Heritage
Differential D2689

common/service: Handle trailing url slashes in lookup_origin
ClosedPublic
Actions

Authored by anlambert on Feb 18 2020, 2:01 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS56fb869644ad: common/service: Handle trailing url slashes in lookup_origin
Summary

It will enable to find an origin when users provide urls with or without a trailing slash.

Related to T1852
Related to T2289

Diff Detail

Repository
rDWAPPS Web applications
Branch
lookup-origin-trailing-slash
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10682
Build 16019: Cypress tests for swh-web diffsJenkins
Build 16018: tox-on-jenkinsJenkins
Build 16017: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 18 2020, 2:01 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 18 2020, 2:01 PM
vlorentz requested changes to this revision.Feb 18 2020, 2:09 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/web/common/service.py
235

at this point, len(origins) is 3.

With either the URL missing the last character, or two slashes at the end.

This revision now requires changes to proceed.Feb 18 2020, 2:09 PM
swh-public-ci added a comment.Feb 18 2020, 2:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/970/ for more details.

anlambert updated this revision to Diff 9607.Feb 18 2020, 2:15 PM

Update: Check extra origin urls only when required

anlambert updated this revision to Diff 9611.Feb 18 2020, 2:22 PM

Update: Improve implementation (use endswith + if/else)

swh-public-ci added a comment.Feb 18 2020, 2:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/579/ for more details.

Harbormaster completed remote builds in B10664: Diff 9603.Feb 18 2020, 2:23 PM
swh-public-ci added a comment.Feb 18 2020, 2:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/971/ for more details.

swh-public-ci added a comment.Feb 18 2020, 2:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/973/ for more details.

swh-public-ci added a comment.Feb 18 2020, 2:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/580/ for more details.

Harbormaster completed remote builds in B10668: Diff 9607.Feb 18 2020, 2:48 PM
swh-public-ci added a comment.Feb 18 2020, 3:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/582/ for more details.

Harbormaster completed remote builds in B10672: Diff 9611.Feb 18 2020, 3:05 PM
vlorentz accepted this revision.Feb 18 2020, 4:25 PM
This revision is now accepted and ready to land.Feb 18 2020, 4:25 PM
anlambert updated this revision to Diff 9621.Feb 18 2020, 4:45 PM

Rebase

This revision was landed with ongoing or failed builds.Feb 18 2020, 4:47 PM
Closed by commit rDWAPPS56fb869644ad: common/service: Handle trailing url slashes in lookup_origin (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS56fb869644ad: common/service: Handle trailing url slashes in lookup_origin.
swh-public-ci added a comment.Feb 18 2020, 4:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/975/ for more details.

swh-public-ci added a comment.Feb 18 2020, 5:09 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/584/ for more details.

Harbormaster completed remote builds in B10682: Diff 9621.Feb 18 2020, 5:09 PM

Revision Contents
Changeset List

PathSize
swh/
web/
common/
20 lines
tests/
common/
15 lines

Diff 9621

View Options

swh/web/common/service.py

Loading...
View Options

swh/web/tests/common/test_service.py

Loading...
About · Developer information · Legal