Page MenuHomeSoftware Heritage
Differential D286

cookers: rewrite the I/O pipeline with file objects instead of generators
ClosedPublic
Actions

Authored by seirl on Jan 12 2018, 3:53 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Maniphest Tasks
T928: Rewrite the Vault Cookers I/O pipeline with file objects
Commits
rDVAUc5b309cbb3ed: cookers: unify tar building in directory and revision_flat
rDVAU66531b6768a8: revision_gitfast: leverage generators freed by the new IO pipeline for…
rDVAU6253f49f9a2a: cookers: rewrite the I/O pipeline with file objects instead of generators

Diff Detail

Repository
rDVAU Software Heritage Vault
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1155
Build 1499: arc lint + arc unit

Event Timeline

seirl created this revision.Jan 12 2018, 3:53 PM
seirl added a reviewer: Reviewers.Jan 12 2018, 3:53 PM
seirl added a task: T928: Rewrite the Vault Cookers I/O pipeline with file objects.
seirl updated this revision to Diff 963.Jan 12 2018, 4:04 PM
  • cookers: unify tar building in directory and revision_flat
Harbormaster completed remote builds in B1156: Diff 963.Jan 12 2018, 4:04 PM
seirl updated this revision to Diff 966.Jan 12 2018, 6:17 PM
  • revision_gitfast: leverage generators freed by the new IO pipeline for filecommands
olasd accepted this revision.Jan 16 2018, 1:23 PM
olasd added a subscriber: olasd.

This does look cleaner than the previous iteration. A simple nitpick inline for you :)

I could bikeshed the BytesIOBundleSizeLimit class name as well (why "Bundle"?), but it's not terribly important.

swh/vault/cookers/base.py
45

shouldn't this call __init__ on the parent class as well?

This revision is now accepted and ready to land.Jan 16 2018, 1:23 PM
Closed by commit rDVAU6253f49f9a2a: cookers: rewrite the I/O pipeline with file objects instead of generators (authored by seirl). · Explain WhyJan 16 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
vault/
cookers/
90 lines
3 lines
8 lines
39 lines
tests/
22 lines
18 lines

Diff 962

View Options

swh/vault/cookers/base.py

Loading...
View Options

swh/vault/cookers/directory.py

Loading...
View Options

swh/vault/cookers/revision_flat.py

Loading...
View Options

swh/vault/cookers/revision_gitfast.py

Loading...
View Options

swh/vault/tests/test_cookers.py

Loading...
View Options

swh/vault/tests/test_cookers_base.py

Loading...
About · Developer information · Legal