Differential D2691

api: Fix error when no extra_encoders is given to negotiate
ClosedPublic
Actions

Authored by anlambert on Feb 18 2020, 4:30 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCORE140a897f4c45: api: Fix error when no extra_encoders is given to negotiate

Summary

Some remote api (for instance the scheduler one) does not declare any
extra_encoders in the negotiate decorator. This was raising an error
when querying any declared endpoint.

(see https://jenkins.softwareheritage.org/job/DSCH/job/tox/349/console)

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

fix-negotiate-no-extra-encoders

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10679
Build 16013: tox-on-jenkins	Jenkins
Build 16012: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 18 2020, 4:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 18 2020, 4:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/418/ for more details.

Harbormaster completed remote builds in B10679: Diff 9618.Feb 18 2020, 4:32 PM

Shouldn't the new test be in a new tests module?

This revision is now accepted and ready to land.Feb 18 2020, 4:38 PM

Closed by commit rDCORE140a897f4c45: api: Fix error when no extra_encoders is given to negotiate (authored by anlambert). · Explain WhyFeb 18 2020, 4:44 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDCORE140a897f4c45: api: Fix error when no extra_encoders is given to negotiate.

Revision Contents
Changeset List

Path

Size

swh/

core/

api/

__init__.py

2 lines

tests/

test_rpc_server.py

20 lines

Diff 9618

View Options

swh/core/api/init.py

View Options

swh/core/api/tests/test_rpc_server.py

api: Fix error when no extra_encoders is given to negotiateClosedPublicActions