Passes them all to the backend instead of silently dropping them all
if any of them is not missing.
Depends on D2662.
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDSTO29b09486ecf0: Fix FilteringProxy to not drop skipped-contents with a missing sha1_git.
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- FilteringProxy-none-sha1_git
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10660 Build 15975: tox-on-jenkins Jenkins Build 15974: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/994/ for more details.
Comment Actions
I guess this is the minimal step to unbreak the logic, but I'm not fond of what this is doing at all: the "key" for a skipped content really is the quadruple of hashes, some potentially null; not any single one of them.
At some point this logic should be adapted to use a proper key tuple instead of a single hash.
Comment Actions
Yes indeed. The point of this proxy is not to be optimal in its detection, but to save some bandwidth in practice, so I think it's good enough this way
Comment Actions
Well. If we consider the case of two different contents with an identical sha1_git, different other_hashes, and a size larger than the limit, in practice the current implementation of the filter would make one mask the other.
This is the edge of an edge case that shouldn't show up in practice, of course. But we should note it down and fix that eventually.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1002/ for more details.