Hello guys this is my first contribution ;) .
Methods:
- origin_metadata_add
- tool_add
- metadata_provider_add
Now add objects to self._objects so counters return the good value
Related: T1377
Details
Details
- Reviewers
douardda joachimf - Group Reviewers
Reviewers - Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0
Added test in the functions related to the addition
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- compute-all-counters
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 10426 Build 15523: tox-on-jenkins Jenkins Build 15522: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/958/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/958/console
Comment Actions
Thanks for the contribution.
You must however ensure tests pass ok before we can accept it. Note that the tests you modify (in tests/test_storage.py) are executed by all the storage backends (postgres, cassandra and the in_memory one you really are targeting here). So make sure they are still OK with all the backends.
Comment Actions
Thanks for the answer I will remove the tests, however I struggle a lot to start the original tests in local for this package.
Comment Actions
Hi, this module was refactored last month and this diff doesn't apply anymore, so I'm closing it