Page MenuHomeSoftware Heritage
Differential D2604

assets: Fix bug in elementsfrompoint-polyfill
ClosedPublic
Actions

Authored by anlambert on Jan 30 2020, 3:00 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPSd4405005c9db: assets: Fix bug in elementsfrompoint-polyfill
Summary

Current implementation of polyfill for document.elementsFromPoint is buggy,
so fix it to avoid js errors in old browsers.

Issue spotted thanks to sentry: https://sentry.softwareheritage.org/organizations/swh/issues/443/?project=13

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 30 2020, 3:00 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 30 2020, 3:00 PM
swh-public-ci added a comment.Jan 30 2020, 3:03 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/912/ for more details.

anlambert updated this revision to Diff 9314.Jan 30 2020, 3:07 PM

Update yarn.lock

swh-public-ci added a comment.Jan 30 2020, 3:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/520/ for more details.

Harbormaster completed remote builds in B10375: Diff 9313.Jan 30 2020, 3:10 PM
swh-public-ci added a comment.Jan 30 2020, 3:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/913/ for more details.

swh-public-ci added a comment.Jan 30 2020, 3:19 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/521/ for more details.

Harbormaster completed remote builds in B10376: Diff 9314.Jan 30 2020, 3:19 PM
vlorentz accepted this revision.Jan 30 2020, 3:20 PM
This revision is now accepted and ready to land.Jan 30 2020, 3:20 PM
Closed by commit rDWAPPSd4405005c9db: assets: Fix bug in elementsfrompoint-polyfill (authored by anlambert). · Explain WhyJan 30 2020, 3:21 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSd4405005c9db: assets: Fix bug in elementsfrompoint-polyfill.

Revision Contents
Changeset List

PathSize
1 line
swh/
web/
assets/
src/
bundles/
vendors/
42 lines
2 lines
5 lines

Diff 9315

View Options

package.json

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines def post_load(self, success=True):
return return
revisions = self.objects['revision'] revisions = self.objects['revision']
# Retrieve the revision # Retrieve the revision
[rev_id] = revisions.keys() [rev_id] = revisions.keys()
rev = revisions[rev_id] rev = revisions[rev_id]
if rev_id: if rev_id:
rev_id = hashutil.hash_to_hex(rev_id) rev_id = hashutil.hash_to_hex(rev_id)
dir_id = rev['directory'] dir_id = rev['directory']
if dir_id: if dir_id:
dir_id = hashutil.hash_to_hex(dir_id) dir_id = hashutil.hash_to_hex(dir_id)
# update the deposit's status to success with its # update the deposit's status to success with its
# revision-id and directory-id # revision-id and directory-id
self.client.status_update(self.deposit_update_url, self.client.status_update(
self.deposit_update_url,
status='done', status='done',
revision_id=rev_id, revision_id=rev_id,
directory_id=dir_id) directory_id=dir_id,
origin_url=self.origin['url'])
except Exception: except Exception:
self.log.exception( self.log.exception(
'Problem when trying to update the deposit\'s status') 'Problem when trying to update the deposit\'s status')
def cleanup(self): def cleanup(self):
"""Clean up temporary directory where we retrieved the tarball. """Clean up temporary directory where we retrieved the tarball.
""" """
super().cleanup() super().cleanup()
self.temporary_directory.cleanup() self.temporary_directory.cleanup()
View Options

swh/web/assets/src/bundles/vendors/elementsfrompoint-polyfill.js

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines def post_load(self, success=True):
return return
revisions = self.objects['revision'] revisions = self.objects['revision']
# Retrieve the revision # Retrieve the revision
[rev_id] = revisions.keys() [rev_id] = revisions.keys()
rev = revisions[rev_id] rev = revisions[rev_id]
if rev_id: if rev_id:
rev_id = hashutil.hash_to_hex(rev_id) rev_id = hashutil.hash_to_hex(rev_id)
dir_id = rev['directory'] dir_id = rev['directory']
if dir_id: if dir_id:
dir_id = hashutil.hash_to_hex(dir_id) dir_id = hashutil.hash_to_hex(dir_id)
# update the deposit's status to success with its # update the deposit's status to success with its
# revision-id and directory-id # revision-id and directory-id
self.client.status_update(self.deposit_update_url, self.client.status_update(
self.deposit_update_url,
status='done', status='done',
revision_id=rev_id, revision_id=rev_id,
directory_id=dir_id) directory_id=dir_id,
origin_url=self.origin['url'])
except Exception: except Exception:
self.log.exception( self.log.exception(
'Problem when trying to update the deposit\'s status') 'Problem when trying to update the deposit\'s status')
def cleanup(self): def cleanup(self):
"""Clean up temporary directory where we retrieved the tarball. """Clean up temporary directory where we retrieved the tarball.
""" """
super().cleanup() super().cleanup()
self.temporary_directory.cleanup() self.temporary_directory.cleanup()
View Options

swh/web/assets/src/bundles/vendors/index.js

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines def post_load(self, success=True):
return return
revisions = self.objects['revision'] revisions = self.objects['revision']
# Retrieve the revision # Retrieve the revision
[rev_id] = revisions.keys() [rev_id] = revisions.keys()
rev = revisions[rev_id] rev = revisions[rev_id]
if rev_id: if rev_id:
rev_id = hashutil.hash_to_hex(rev_id) rev_id = hashutil.hash_to_hex(rev_id)
dir_id = rev['directory'] dir_id = rev['directory']
if dir_id: if dir_id:
dir_id = hashutil.hash_to_hex(dir_id) dir_id = hashutil.hash_to_hex(dir_id)
# update the deposit's status to success with its # update the deposit's status to success with its
# revision-id and directory-id # revision-id and directory-id
self.client.status_update(self.deposit_update_url, self.client.status_update(
self.deposit_update_url,
status='done', status='done',
revision_id=rev_id, revision_id=rev_id,
directory_id=dir_id) directory_id=dir_id,
origin_url=self.origin['url'])
except Exception: except Exception:
self.log.exception( self.log.exception(
'Problem when trying to update the deposit\'s status') 'Problem when trying to update the deposit\'s status')
def cleanup(self): def cleanup(self):
"""Clean up temporary directory where we retrieved the tarball. """Clean up temporary directory where we retrieved the tarball.
""" """
super().cleanup() super().cleanup()
self.temporary_directory.cleanup() self.temporary_directory.cleanup()
View Options

yarn.lock

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines def post_load(self, success=True):
return return
revisions = self.objects['revision'] revisions = self.objects['revision']
# Retrieve the revision # Retrieve the revision
[rev_id] = revisions.keys() [rev_id] = revisions.keys()
rev = revisions[rev_id] rev = revisions[rev_id]
if rev_id: if rev_id:
rev_id = hashutil.hash_to_hex(rev_id) rev_id = hashutil.hash_to_hex(rev_id)
dir_id = rev['directory'] dir_id = rev['directory']
if dir_id: if dir_id:
dir_id = hashutil.hash_to_hex(dir_id) dir_id = hashutil.hash_to_hex(dir_id)
# update the deposit's status to success with its # update the deposit's status to success with its
# revision-id and directory-id # revision-id and directory-id
self.client.status_update(self.deposit_update_url, self.client.status_update(
self.deposit_update_url,
status='done', status='done',
revision_id=rev_id, revision_id=rev_id,
directory_id=dir_id) directory_id=dir_id,
origin_url=self.origin['url'])
except Exception: except Exception:
self.log.exception( self.log.exception(
'Problem when trying to update the deposit\'s status') 'Problem when trying to update the deposit\'s status')
def cleanup(self): def cleanup(self):
"""Clean up temporary directory where we retrieved the tarball. """Clean up temporary directory where we retrieved the tarball.
""" """
super().cleanup() super().cleanup()
self.temporary_directory.cleanup() self.temporary_directory.cleanup()
About · Developer information · Legal