Page MenuHomeSoftware Heritage
Differential D2600

Remove last references to non-intrinsic origin identifiers
ClosedPublic
Actions

Authored by anlambert on Jan 29 2020, 4:04 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPSff9ad4f9392d: Remove last references to non-intrinsic origin identifiers
Summary

Stop leaking those ids in results from the /api/1/origins/ endpoint.

Remove any reference to those ids in the doc and the code.

Related to T1791

Diff Detail

Repository
rDWAPPS Web applications
Branch
remove-origin-id-refs
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10357
Build 15404: Cypress tests for swh-web diffsJenkins
Build 15403: tox-on-jenkinsJenkins
Build 15402: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 29 2020, 4:04 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 29 2020, 4:04 PM
swh-public-ci added a comment.Jan 29 2020, 4:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/910/ for more details.

anlambert updated this revision to Diff 9297.Jan 29 2020, 4:11 PM

Update: Check if the 'id' key value exists before attempting to delete it (for the non postgres storage backends)

swh-public-ci added a comment.Jan 29 2020, 4:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/911/ for more details.

swh-public-ci added a comment.Jan 29 2020, 4:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/518/ for more details.

Harbormaster completed remote builds in B10356: Diff 9296.Jan 29 2020, 4:16 PM
swh-public-ci added a comment.Jan 29 2020, 4:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/519/ for more details.

Harbormaster completed remote builds in B10357: Diff 9297.Jan 29 2020, 4:26 PM
vlorentz accepted this revision.Jan 29 2020, 4:30 PM
This revision is now accepted and ready to land.Jan 29 2020, 4:30 PM
Closed by commit rDWAPPSff9ad4f9392d: Remove last references to non-intrinsic origin identifiers (authored by anlambert). · Explain WhyJan 29 2020, 4:46 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPSff9ad4f9392d: Remove last references to non-intrinsic origin identifiers.

Revision Contents
Changeset List

PathSize
swh/
web/
api/
views/
7 lines
browse/
views/
2 lines
common/
49 lines
tests/
common/
19 lines

Diff 9297

View Options

swh/web/api/views/origin.py

Loading...
View Options

swh/web/browse/views/origin.py

Loading...
View Options

swh/web/common/origin_visits.py

Loading...
View Options

swh/web/tests/common/test_origin_visits.py

Loading...
About · Developer information · Legal