Page MenuHomeSoftware Heritage
Differential D2572

Add environment variable $SWH_SENTRY_ENVIRONMENT
ClosedPublic
Actions

Authored by vlorentz on Jan 22 2020, 2:07 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCORE0aaab9cfdb3f: Add environment variable $SWH_SENTRY_ENVIRONMENT
Summary

This allows initializing Sentry with the environment the process
is running in (ie. "production" or "staging"), which allows filtering
in the web UI to only show issues happening in one of the environments.

https://docs.sentry.io/enriching-error-data/environments/?platform=python

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 22 2020, 2:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 22 2020, 2:07 PM
swh-public-ci added a comment.Jan 22 2020, 2:10 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/389/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/389/console

Harbormaster failed remote builds in B10233: Diff 9172!Jan 22 2020, 2:10 PM
ardumont accepted this revision.EditedJan 22 2020, 3:25 PM
ardumont added a subscriber: ardumont.

Nice!
Thanks.

Accepted, don't forget to fix the build though.
You are missing mock adaptations for the build to be green ;)

This revision is now accepted and ready to land.Jan 22 2020, 3:25 PM
vlorentz updated this revision to Diff 9179.Jan 22 2020, 3:35 PM

update tests

swh-public-ci added a comment.Jan 22 2020, 3:37 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/390/ for more details.

Harbormaster completed remote builds in B10238: Diff 9179.Jan 22 2020, 3:37 PM
ardumont added a comment.Jan 22 2020, 3:40 PM

fyi, I'm adapting the puppet manifests with this.

vlorentz added a comment.EditedJan 22 2020, 3:47 PM

@ardumont see T2181

ardumont accepted this revision.Jan 22 2020, 6:37 PM
ardumont mentioned this in D2576: sentry: Define setup for swh services (servers, workers, ...).Jan 22 2020, 6:50 PM
Closed by commit rDCORE0aaab9cfdb3f: Add environment variable $SWH_SENTRY_ENVIRONMENT (authored by vlorentz). · Explain WhyJan 22 2020, 7:13 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCORE0aaab9cfdb3f: Add environment variable $SWH_SENTRY_ENVIRONMENT.

Revision Contents
Changeset List

PathSize
swh/
core/
api/
tests/
6 lines
2 lines
tests/
5 lines

Diff 9200

View Options

swh/core/api/tests/test_gunicorn.py

Loading...
View Options

swh/core/sentry.py

Loading...
View Options

swh/core/tests/test_cli.py

Loading...
About · Developer information · Legal