Page MenuHomeSoftware Heritage
Differential D2534

Raise an exception when trying to resolve an origin pid input
ClosedPublic
Actions

Authored by anlambert on Jan 15 2020, 2:12 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS34014ddb5353: resolve_persistent_identifier: Raise an exception for origin pid input
Summary

Origin persistent identifiers are not publicly resolvable as they are not intrinsic.

So raise an exception to get a 400 error code in concerned endpoints.

Diff Detail

Repository
rDWAPPS Web applications
Branch
origin-pid-not-resolvable
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10116
Build 14996: Cypress tests for swh-web diffsJenkins
Build 14995: tox-on-jenkinsJenkins
Build 14994: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 15 2020, 2:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 15 2020, 2:12 PM
swh-public-ci added a comment.Jan 15 2020, 2:19 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/889/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/889/console

Harbormaster failed remote builds in B10116: Diff 9014!Jan 15 2020, 2:19 PM
vlorentz added a subscriber: vlorentz.Jan 15 2020, 2:24 PM
vlorentz added inline comments.
swh/web/common/utils.py
290–292

I think because they are not intrinsic is more confusing than not.

What about Origin PIDs (Persistent Identifiers) are for internal usage only?

anlambert added inline comments.Jan 15 2020, 2:38 PM
swh/web/common/utils.py
290–292

Indeed, this is simpler to understand.

anlambert updated this revision to Diff 9017.Jan 15 2020, 2:41 PM

Update: Simplify exception message.

swh-public-ci added a comment.Jan 15 2020, 2:48 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/497/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/497/console

swh-public-ci added a comment.Jan 15 2020, 2:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/891/ for more details.

vlorentz accepted this revision.Jan 15 2020, 2:52 PM
This revision is now accepted and ready to land.Jan 15 2020, 2:52 PM
swh-public-ci added a comment.Jan 15 2020, 3:02 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/499/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/499/console

Harbormaster failed remote builds in B10119: Diff 9017!Jan 15 2020, 3:02 PM
anlambert updated this revision to Diff 9031.Jan 15 2020, 3:14 PM

Rebase

This revision was landed with ongoing or failed builds.Jan 15 2020, 3:20 PM
Closed by commit rDWAPPS34014ddb5353: resolve_persistent_identifier: Raise an exception for origin pid input (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS34014ddb5353: resolve_persistent_identifier: Raise an exception for origin pid input.
swh-public-ci added a comment.Jan 15 2020, 3:22 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/893/ for more details.

swh-public-ci added a comment.Jan 15 2020, 3:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/501/ for more details.

Harbormaster completed remote builds in B10133: Diff 9031.Jan 15 2020, 3:33 PM

Revision Contents
Changeset List

PathSize
swh/
web/
common/
8 lines
tests/
api/
views/
9 lines
browse/
views/
11 lines

Diff 9014

View Options

swh/web/common/utils.py

Loading...
View Options

swh/web/tests/api/views/test_identifiers.py

Loading...
View Options

swh/web/tests/browse/views/test_identifiers.py

Loading...
About · Developer information · Legal