Page MenuHomeSoftware Heritage
Differential D2405

svn.loader: Migrate to new buffer/filter behavior
ClosedPublic
Actions

Authored by ardumont on Dec 6 2019, 2:51 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDLDSVN4d036c1a0a3d: svn.loader: Migrate to new buffer/filter behavior
Summary

This migrates the code to the latest (yet unpublished) loader-core.

Note: build will fail expectedly for now.

Depends D2403

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9695
Build 14291: tox-on-jenkinsJenkins
Build 14290: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 6 2019, 2:51 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 6 2019, 2:51 PM
ardumont mentioned this in D2403: core.loader: Drop deprecated behavior.Dec 6 2019, 2:51 PM
swh-public-ci added a comment.Dec 6 2019, 2:52 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/44/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/44/console

Harbormaster failed remote builds in B9576: Diff 8493!Dec 6 2019, 2:52 PM
ardumont edited the summary of this revision. (Show Details)Dec 6 2019, 2:53 PM
anlambert accepted this revision.Dec 6 2019, 3:02 PM
anlambert added a subscriber: anlambert.

Looks good !

swh/loader/svn/tests/test_loader.py
37

You can safely remove that entry too as its use is dropped in D2403

This revision is now accepted and ready to land.Dec 6 2019, 3:02 PM
ardumont added inline comments.Dec 6 2019, 3:05 PM
swh/loader/svn/tests/test_loader.py
37

right! thanks!

ardumont updated this revision to Diff 8554.Dec 10 2019, 9:47 AM

Missing update?

swh-public-ci added a comment.Dec 10 2019, 9:49 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/45/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/45/console

Harbormaster failed remote builds in B9634: Diff 8554!Dec 10 2019, 9:49 AM
ardumont updated this revision to Diff 8613.Dec 12 2019, 12:20 PM

Rebase and plug to master

swh-public-ci added a comment.Dec 12 2019, 12:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/46/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/46/console

Harbormaster failed remote builds in B9695: Diff 8613!Dec 12 2019, 12:22 PM
ardumont updated this revision to Diff 8622.Dec 12 2019, 2:09 PM

Update requirements

ardumont updated this revision to Diff 8623.EditedDec 12 2019, 2:10 PM

Update to the latest bug-free version

swh-public-ci added a comment.Dec 12 2019, 2:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/47/ for more details.

Harbormaster completed remote builds in B9704: Diff 8622.Dec 12 2019, 2:11 PM
swh-public-ci added a comment.Dec 12 2019, 2:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/48/ for more details.

Harbormaster completed remote builds in B9705: Diff 8623.Dec 12 2019, 2:12 PM
Closed by commit rDLDSVN4d036c1a0a3d: svn.loader: Migrate to new buffer/filter behavior (authored by ardumont). · Explain WhyDec 12 2019, 2:13 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDSVN4d036c1a0a3d: svn.loader: Migrate to new buffer/filter behavior.

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
svn/
8 lines
tests/
34 lines
38 lines

Diff 8613

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/svn/loader.py

Loading...
View Options

swh/loader/svn/tests/conftest.py

Loading...
View Options

swh/loader/svn/tests/test_loader.py

Loading...
About · Developer information · Legal