Page MenuHomeSoftware Heritage
Differential D2362

Fix a release browsing issue in snapshot context views
ClosedPublic
Actions

Authored by anlambert on Nov 27 2019, 2:46 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS3840dcd4eafa: Rename snapshot_size to snapshot_sizes
rDWAPPS8a6f2ab7deb2: browse: Fix release browsing issue in snapshot context views
Summary

Sometimes, when one tries to browse objects releated to a specific release contained
in a snapshot, a 404 error is raised while the release exists.

The issue was due to the associated snapshot content being truncated to 1000 branches
when the webapp retrieves it.

Error handling when ones tries to browse an invalid release has also been improved.

Related to T2108

Diff Detail

Repository
rDWAPPS Web applications
Branch
browse-releases-fix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9397
Build 13766: Cypress tests for swh-web diffsJenkins
Build 13765: tox-on-jenkinsJenkins
Build 13764: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 27 2019, 2:46 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2019, 2:46 PM
swh-public-ci added a comment.Nov 27 2019, 2:50 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/802/ for more details.

swh-public-ci added a comment.Nov 27 2019, 2:59 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/401/ for more details.

Harbormaster completed remote builds in B9396: Diff 8324.Nov 27 2019, 2:59 PM
vlorentz accepted this revision.Nov 27 2019, 3:12 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/web/browse/views/utils/snapshot_context.py
86

snapshot_size is a dict of sizes, so it should be plural (snapshot_sizes)

swh/web/tests/browse/views/test_origin.py
513

this line should be in a finally: clause, to not break other tests if this one crashes.

This revision is now accepted and ready to land.Nov 27 2019, 3:12 PM
anlambert added inline comments.Nov 27 2019, 3:39 PM
swh/web/browse/views/utils/snapshot_context.py
86

Ack will add a new commit in the diff for global renaming

swh/web/tests/browse/views/test_origin.py
513

ack

anlambert updated this revision to Diff 8326.Nov 27 2019, 3:42 PM

Update: Address @vlorentz comments

swh-public-ci added a comment.Nov 27 2019, 3:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/803/ for more details.

swh-public-ci added a comment.Nov 27 2019, 3:51 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/402/ for more details.

Harbormaster completed remote builds in B9397: Diff 8326.Nov 27 2019, 3:51 PM
anlambert updated this revision to Diff 8332.Nov 27 2019, 4:07 PM

Rebase

This revision was landed with ongoing or failed builds.Nov 27 2019, 4:08 PM
Closed by commit rDWAPPS8a6f2ab7deb2: browse: Fix release browsing issue in snapshot context views (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS8a6f2ab7deb2: browse: Fix release browsing issue in snapshot context views.
anlambert added a commit: rDWAPPS3840dcd4eafa: Rename snapshot_size to snapshot_sizes.
Harbormaster failed remote builds in B9403: Diff 8332!Nov 27 2019, 4:08 PM
swh-public-ci added a comment.Nov 27 2019, 4:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/806/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/806/console

swh-public-ci added a comment.Nov 27 2019, 4:14 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/405/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/405/console

Revision Contents
Changeset List

PathSize
swh/
web/
browse/
6 lines
views/
utils/
44 lines
common/
24 lines
templates/
includes/
8 lines
8 lines
tests/
browse/
views/
61 lines
4 lines
2 lines

Diff 8326

View Options

swh/web/browse/utils.py

Loading...
View Options

swh/web/browse/views/utils/snapshot_context.py

Loading...
View Options

swh/web/common/service.py

Loading...
View Options

swh/web/templates/includes/snapshot-context.html

Loading...
View Options

swh/web/templates/includes/top-navigation.html

Loading...
View Options

swh/web/tests/browse/views/test_origin.py

Loading...
View Options

swh/web/tests/browse/views/test_release.py

Loading...
View Options

swh/web/tests/strategies.py

Loading...
About · Developer information · Legal