Page MenuHomeSoftware Heritage
Differential D2355

docker: Stop pinning gunicorn
ClosedPublic
Actions

Authored by olasd on Nov 26 2019, 3:21 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDENV7178d53b9d9a: docker: Stop pinning gunicorn
Summary

20.0.1-3 have been released and fix the issue we were working around.

Test Plan

Rebuild swh/stack and restart all the things

Diff Detail

Repository
rDENV Development environment
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9386
Build 13748: arc lint + arc unit

Event Timeline

olasd created this revision.Nov 26 2019, 3:21 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 26 2019, 3:21 PM
Harbormaster completed remote builds in B9381: Diff 8306.Nov 26 2019, 3:21 PM
anlambert requested changes to this revision.Nov 26 2019, 3:40 PM
anlambert added a subscriber: anlambert.
anlambert added inline comments.
docker/Dockerfile
26

You should keep the pip install gunicorn instruction as we do not explicitely declare the dependency in the requirements.txt files.

(swh) ✔ ~/swh/swh-environment [master|✚ 1⚑ 5] 
15:37 $ find -name requirements.txt | grep gunicorn
(swh) ✘-1 ~/swh/swh-environment [master|✚ 1⚑ 5]
This revision now requires changes to proceed.Nov 26 2019, 3:40 PM
olasd updated this revision to Diff 8311.Nov 26 2019, 4:23 PM

Still install gunicorn

Harbormaster completed remote builds in B9386: Diff 8311.Nov 26 2019, 4:23 PM
anlambert accepted this revision.Nov 26 2019, 4:24 PM
This revision is now accepted and ready to land.Nov 26 2019, 4:24 PM
olasd updated this revision to Diff 8312.Nov 26 2019, 4:34 PM

Rebase

Harbormaster completed remote builds in B9387: Diff 8312.Nov 26 2019, 4:34 PM
Closed by commit rDENV7178d53b9d9a: docker: Stop pinning gunicorn (authored by olasd). · Explain WhyNov 26 2019, 4:34 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDENV7178d53b9d9a: docker: Stop pinning gunicorn.

Revision Contents
Changeset List

PathSize
docker/
2 lines

Diff 8311

View Options

docker/Dockerfile

Loading...
About · Developer information · Legal