Page MenuHomeSoftware Heritage

cache: objstorage implementation independant (no longer requires pathslicing)
ClosedPublic

Authored by seirl on Sep 14 2017, 6:23 PM.

Diff Detail

Repository
rDVAU Software Heritage Vault
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1007
Build 1332: arc lint + arc unit

Event Timeline

This change is needed to be able to use a remote objstorage for the Vault.

zack added inline comments.
swh/vault/api/server.py
28–36

I understand this was here before and hence not your fault :-), but why do we hard-code a /tmp rooted path in the API server implementation?
That doesn't look good…

swh/vault/api/server.py
28–36

I guess it's because the API server is essentially the only way to instanciate a Vault, so the default config is put here as this is the main entry point.

swh/vault/api/server.py
28–36

If you see a better place to put that, and better default values, I'm totally open to changing it, but I want it to be part of the default config so that we know the things that can be overwritten in the config.

  • config: use canonical swh paths
This revision is now accepted and ready to land.Sep 18 2017, 2:45 PM
This revision was automatically updated to reflect the committed changes.