Paths

Table of Contentst

Differential D2345

browse: Ensure display of valid utf-8 contents detected as binary
ClosedPublic
Actions

Authored by anlambert on Nov 22 2019, 5:29 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDWAPPS41cc2cbdc5bf: browse: Ensure display of valid utf-8 contents detected as binary

Summary

libmagic sometimes erroneously detects textual contents as binary while they are
valid UTF-8 encoded files, so ensure they can be displayed in swh-web/browse.

Also add encoding information in the message printed in the content view when a
content can not be displayed.

Related to T2082

Test Plan

Turns out that this kind of content are present in the sample repositories used to populate the sample archive for the tests.
So add a new test for that corner case.

Diff Detail

Repository

rDWAPPS Web applications

Branch

fix-libmagic-encoding-detection-errors

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9342
Build 13678: Cypress tests for swh-web diffs	Jenkins
Build 13677: tox-on-jenkins	Jenkins
Build 13676: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 22 2019, 5:29 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 22 2019, 5:29 PM

anlambert edited the test plan for this revision. (Show Details)Nov 22 2019, 5:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/794/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/393/ for more details.

Harbormaster completed remote builds in B9342: Diff 8071.Nov 22 2019, 5:39 PM

ardumont added a subscriber: ardumont.Nov 22 2019, 5:39 PM

ardumont added inline comments.

swh/web/templates/includes/content-display.html
44	`cannot`

ardumont accepted this revision.Nov 22 2019, 5:50 PM

This revision is now accepted and ready to land.Nov 22 2019, 5:50 PM

Update: Fix typo

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/795/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/394/ for more details.

Harbormaster completed remote builds in B9350: Diff 8077.Nov 25 2019, 10:59 AM

Closed by commit rDWAPPS41cc2cbdc5bf: browse: Ensure display of valid utf-8 contents detected as binary (authored by anlambert). · Explain WhyNov 25 2019, 11:32 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS41cc2cbdc5bf: browse: Ensure display of valid utf-8 contents detected as binary.

Revision Contents
Changeset List

Path

Size

swh/

web/

browse/

12 lines

templates/

includes/

content-display.html

3 lines

tests/

browse/

views/

test_content.py

19 lines

18 lines

Diff 8071

swh/web/browse/utils.py

Loading...

swh/web/templates/includes/content-display.html

Loading...

swh/web/tests/browse/views/test_content.py

Loading...

swh/web/tests/strategies.py

Loading...