Differential D2268

Add swh-search to docker env
ClosedPublic
Actions

Authored by vlorentz on Nov 13 2019, 3:00 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDENVd1992ffd42ab: Add swh-search.
rCDFDd1992ffd42ab: Add swh-search.

Summary

Note that swh-web does not use it for now.

Diff Detail

Repository

rCDFD Dockerfiles for developers

Branch

add-swh-search

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 8998
Build 13149: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 13 2019, 3:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 13 2019, 3:00 PM

Harbormaster completed remote builds in B8995: Diff 7813.Nov 13 2019, 3:00 PM

remove .swo file

Harbormaster completed remote builds in B8996: Diff 7814.Nov 13 2019, 3:01 PM

vlorentz planned changes to this revision.Nov 13 2019, 3:04 PM

remove my custom changes

Harbormaster completed remote builds in B8998: Diff 7816.Nov 13 2019, 3:20 PM

ardumont added a subscriber: ardumont.Nov 13 2019, 5:16 PM

ardumont added inline comments.

services/swh-search/entrypoint.sh
29	wsgi module is back! we removed those from everywhere else... It's unrelated to this diff though, more swh-search repository in general. Might as well reference it here though. Related T2080#38517

It'd be better to remove the wsgi module to align with other swh modules.

Other than that, everything seems fine.

This revision is now accepted and ready to land.Nov 13 2019, 5:17 PM

use app factory instead of wsgi module.

Harbormaster completed remote builds in B9016: Diff 7828.Nov 14 2019, 12:20 PM

Closed by commit rCDFDd1992ffd42ab: Add swh-search. (authored by vlorentz). · Explain WhyNov 14 2019, 12:20 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rCDFDd1992ffd42ab: Add swh-search..

vlorentz added a commit: rDENVd1992ffd42ab: Add swh-search..Nov 26 2019, 1:35 PM

Revision Contents
Changeset List

Path

Size

conf/

5 lines

search_journal_client_objects.yml

10 lines

docker-compose.search.yml

39 lines

env/

elasticsearch.env

1 line

services/

swh-search-journal-client-objects/

19 lines

swh-search/

31 lines

Diff 7816

conf/search.yml

Loading...

conf/search_journal_client_objects.yml

Loading...

docker-compose.search.yml

Loading...

env/elasticsearch.env

Loading...

services/swh-search-journal-client-objects/entrypoint.sh

Loading...

services/swh-search/entrypoint.sh

Loading...