Differential D2260

indexing lister: Force bounds of integer ranges to be integers
ClosedPublic
Actions

Authored by olasd on Nov 12 2019, 5:54 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLS2c5528ef599e: indexing lister: Force bounds of integer ranges to be integers

Summary

The current status generates floating-point bounds for integers; This
in turn prevents postgresql from running a proper index scan, nullifying all the
work we've done to avoid table scans...

Depends on D2258

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 12 2019, 5:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 12 2019, 5:54 PM

olasd added a child revision: D2262: indexing lister: Avoid generating empty or duplicate ranges when partitioning.Nov 12 2019, 5:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/487/ for more details.

Harbormaster completed remote builds in B8967: Diff 7790.Nov 12 2019, 5:59 PM

Looks good.

This revision is now accepted and ready to land.Nov 13 2019, 11:46 AM

Closed by commit rDLS2c5528ef599e: indexing lister: Force bounds of integer ranges to be integers (authored by olasd). · Explain WhyNov 13 2019, 1:09 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLS2c5528ef599e: indexing lister: Force bounds of integer ranges to be integers.

Revision Contents
Changeset List

Path

Size

swh/

lister/

core/

indexing_lister.py

3 lines

tests/

test_indexing_lister.py

17 lines

Diff 7807

View Options

swh/lister/core/indexing_lister.py