Page MenuHomeSoftware Heritage
Differential D2232

lister.cli: Clarify cli's configuration loading step
ClosedPublic
Actions

Authored by ardumont on Nov 7 2019, 4:08 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDLSea7a08d05ddb: lister.debian: Actually use the db_engine passed to the hook function
rDLSeebbc859fc6c: lister.cli: Clarify configuration loading step
Summary

lister.debian: Actually use the db_engine passed to the hook function

The end goal being to actually be able to use it successfully (it did not work).

Test Plan
  • tox
  • Initialize a new db from scratch:
swh lister --db-url "postgresql:///?service=admin-staging-swh-lister" db-init

Diff Detail

Repository
rDLS Listers
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8869
Build 12941: tox-on-jenkinsJenkins
Build 12940: arc lint + arc unit

Event Timeline

ardumont created this revision.Nov 7 2019, 4:08 PM
swh-public-ci added a comment.Nov 7 2019, 4:11 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/477/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/477/console

Harbormaster failed remote builds in B8868: Diff 7699!Nov 7 2019, 4:11 PM
ardumont updated this revision to Diff 7700.Nov 7 2019, 4:13 PM

Rework commit order

swh-public-ci added a comment.Nov 7 2019, 4:16 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/478/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/478/console

Harbormaster failed remote builds in B8869: Diff 7700!Nov 7 2019, 4:16 PM
ardumont updated this revision to Diff 7718.EditedNov 7 2019, 6:08 PM

Reuse same configuration in tests without duplicating it

swh-public-ci added a comment.Nov 7 2019, 6:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/479/ for more details.

Harbormaster completed remote builds in B8887: Diff 7718.Nov 7 2019, 6:11 PM
ardumont updated this revision to Diff 7720.Nov 8 2019, 10:51 AM
  • lister.cli: Clarify configuration loading step
ardumont retitled this revision from lister.cli: Make the cli override through db-url or config-file work to lister.cli: Clarify cli's configuration loading step.Nov 8 2019, 10:53 AM
ardumont edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Nov 8 2019, 10:54 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/480/ for more details.

Harbormaster completed remote builds in B8889: Diff 7720.Nov 8 2019, 10:54 AM
douardda accepted this revision.Nov 8 2019, 10:57 AM
This revision is now accepted and ready to land.Nov 8 2019, 10:57 AM
Closed by commit rDLSeebbc859fc6c: lister.cli: Clarify configuration loading step (authored by ardumont). · Explain WhyNov 8 2019, 10:59 AM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLSeebbc859fc6c: lister.cli: Clarify configuration loading step.
ardumont added a commit: rDLSea7a08d05ddb: lister.debian: Actually use the db_engine passed to the hook function.

Revision Contents
Changeset List

PathSize
swh/
lister/
5 lines
core/
1 line
debian/
44 lines
tests/
2 lines

Diff 7700

View Options

swh/lister/cli.py

Loading...
View Options

swh/lister/core/models.py

Loading...
View Options

swh/lister/debian/__init__.py

Loading...
View Options

swh/lister/debian/tests/conftest.py

Loading...
About · Developer information · Legal