Add error logging to KafkaJournalWriter.
ClosedPublic
Actions

Authored by vlorentz on Sep 18 2019, 5:18 PM.

Details

Reviewers

Group Reviewers

Commits

rDJNL04c7bc283f40: Add error logging to KafkaJournalWriter.
rDJNLebe0a5cb8a9a: Make KafkaJournalWriter support a list as 'brokers'.

Summary

Depends on D2002

Diff Detail

Repository

rDJNL Journal infrastructure

Branch

kafka-producer-logging

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 7841
Build 11279: tox-on-jenkins	Jenkins
Build 11278: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 18 2019, 5:18 PM

olasd added inline comments.Sep 18 2019, 5:24 PM

swh/journal/writer/kafka.py
45–47	`self._error_cb(error)`?

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/257/ for more details.

Harbormaster completed remote builds in B7840: Diff 6732.Sep 18 2019, 5:24 PM

deduplicate code

vlorentz marked an inline comment as done.Sep 18 2019, 5:26 PM

olasd accepted this revision.Sep 18 2019, 5:26 PM

This revision is now accepted and ready to land.Sep 18 2019, 5:26 PM

rebase

This revision was landed with ongoing or failed builds.Sep 18 2019, 5:28 PM

Closed by commit rDJNLebe0a5cb8a9a: Make KafkaJournalWriter support a list as 'brokers'. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDJNLebe0a5cb8a9a: Make KafkaJournalWriter support a list as 'brokers'..

vlorentz added a commit: rDJNL04c7bc283f40: Add error logging to KafkaJournalWriter..

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/258/ for more details.

Harbormaster completed remote builds in B7841: Diff 6733.Sep 18 2019, 5:29 PM

Harbormaster failed remote builds in B7844: Diff 6736!

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/261/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/261/console

Revision Contents
Changeset List

Path

Size

swh/

journal/

writer/

kafka.py

14 lines

Diff 6733

View Options

swh/journal/writer/kafka.py

Add error logging to KafkaJournalWriter.ClosedPublicActions