Page MenuHomeSoftware Heritage
Differential D1774

cypress: Add tests for visits
ClosedPublic
Actions

Authored by kalpitk on Jul 25 2019, 9:07 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS55ea8aa13d73: cypress: Test origin visits

Diff Detail

Event Timeline

kalpitk created this revision.Jul 25 2019, 9:07 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 25 2019, 9:07 PM
swh-public-ci added a comment.Jul 25 2019, 9:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/631/ for more details.

swh-public-ci added a comment.Jul 25 2019, 9:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/227/ for more details.

Harbormaster completed remote builds in B7036: Diff 5995.Jul 25 2019, 9:14 PM
kalpitk updated this revision to Diff 6008.Jul 26 2019, 9:31 PM
  • add test
swh-public-ci added a comment.Jul 26 2019, 9:37 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/633/ for more details.

swh-public-ci added a comment.Jul 26 2019, 9:38 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/229/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/229/console

Harbormaster failed remote builds in B7048: Diff 6008!Jul 26 2019, 9:38 PM
kalpitk updated this revision to Diff 6026.Jul 29 2019, 4:28 PM

Refactor and add tests

swh-public-ci added a comment.Jul 29 2019, 4:34 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/635/ for more details.

swh-public-ci added a comment.Jul 29 2019, 4:35 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/231/ for more details.

Harbormaster completed remote builds in B7064: Diff 6026.Jul 29 2019, 4:35 PM
anlambert added a subscriber: anlambert.Jul 29 2019, 5:30 PM

@kalpitk , can you rebase that diff on origin/master. I can not arc patch it locally otherwise.

kalpitk retitled this revision from [WIP] Add tests for visits to Add tests for visits.Jul 29 2019, 7:23 PM
kalpitk updated this revision to Diff 6028.Jul 29 2019, 7:24 PM

rebase

kalpitk retitled this revision from Add tests for visits to cypress: Add tests for visits.Jul 29 2019, 7:27 PM
swh-public-ci added a comment.Jul 29 2019, 7:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/636/ for more details.

swh-public-ci added a comment.Jul 29 2019, 7:33 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/232/ for more details.

Harbormaster completed remote builds in B7065: Diff 6028.Jul 29 2019, 7:33 PM
anlambert accepted this revision.Jul 30 2019, 12:01 PM

Looks good to me. Just a small nitpick: can you rename the cypress test file to origin-visits.spec.js before landing this.

This revision is now accepted and ready to land.Jul 30 2019, 12:01 PM
kalpitk updated this revision to Diff 6029.Jul 30 2019, 12:24 PM

Rename visits -> origin-visits

swh-public-ci added a comment.Jul 30 2019, 12:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/637/ for more details.

swh-public-ci added a comment.Jul 30 2019, 12:31 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/233/ for more details.

Harbormaster completed remote builds in B7066: Diff 6029.Jul 30 2019, 12:31 PM
kalpitk updated this revision to Diff 6030.Jul 30 2019, 12:32 PM

minor changes

kalpitk added inline comments.Jul 30 2019, 12:34 PM
cypress/integration/origin-visits.spec.js
23 ↗(On Diff #6030)

@anlambert Added this to prevent tests from failing when the visit is filtered out.

swh-public-ci added a comment.Jul 30 2019, 12:37 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/638/ for more details.

swh-public-ci added a comment.Jul 30 2019, 12:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/234/ for more details.

Harbormaster completed remote builds in B7067: Diff 6030.Jul 30 2019, 12:39 PM
anlambert added inline comments.Jul 30 2019, 1:31 PM
cypress/integration/origin-visits.spec.js
23 ↗(On Diff #6030)

Right, this should indeed avoid possible errors. Let's land this !

Closed by commit rDWAPPS55ea8aa13d73: cypress: Test origin visits (authored by kalpitk). · Explain WhyJul 30 2019, 1:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cypress/
integration/
46 lines
utils/
18 lines

Diff 5995

View Options

cypress/integration/visits.spec.js

Loading...
View Options

cypress/utils/index.js

Loading...
About · Developer information · Legal