Page MenuHomeSoftware Heritage

cypress: Add tests for visits
ClosedPublic

Authored by kalpitk on Jul 25 2019, 9:07 PM.

Details

Diff Detail

Event Timeline

@kalpitk , can you rebase that diff on origin/master. I can not arc patch it locally otherwise.

kalpitk retitled this revision from [WIP] Add tests for visits to Add tests for visits.Jul 29 2019, 7:23 PM
kalpitk retitled this revision from Add tests for visits to cypress: Add tests for visits.Jul 29 2019, 7:27 PM

Looks good to me. Just a small nitpick: can you rename the cypress test file to origin-visits.spec.js before landing this.

This revision is now accepted and ready to land.Jul 30 2019, 12:01 PM

Rename visits -> origin-visits

cypress/integration/origin-visits.spec.js
23 ↗(On Diff #6030)

@anlambert Added this to prevent tests from failing when the visit is filtered out.

cypress/integration/origin-visits.spec.js
23 ↗(On Diff #6030)

Right, this should indeed avoid possible errors. Let's land this !

This revision was automatically updated to reflect the committed changes.