Page MenuHomeSoftware Heritage
Differential D1665

Make all endpoints support origin urls instead of ids.
ClosedPublic
Actions

Authored by vlorentz on Jun 28 2019, 8:53 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDSTOCd98f0658c179: Make all endpoints support origin urls instead of ids.
rDSTOd98f0658c179: Make all endpoints support origin urls instead of ids.
Summary

Depends on D1664.

Diff Detail

Repository
rDSTO Storage manager
Branch
proptest-use_url2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6612
Build 9229: tox-on-jenkinsJenkins
Build 9228: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 28 2019, 8:53 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 28 2019, 8:53 PM
swh-public-ci added a comment.Jun 28 2019, 9:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/515/ for more details.

Harbormaster completed remote builds in B6577: Diff 5570.Jun 28 2019, 9:14 PM
vlorentz added a child revision: D1666: Add origin-url alternative to some endpoints that take an origin-id..Jul 1 2019, 11:54 AM
anlambert accepted this revision.Jul 1 2019, 3:08 PM
anlambert added a subscriber: anlambert.

Apart adding some variables in the tests as in D1664, looks good to me.

swh/storage/tests/test_storage.py
1621

Same comment as in D1664, using a variable to store the origin identifier or url would improve code readability.

This revision is now accepted and ready to land.Jul 1 2019, 3:08 PM
vlorentz updated this revision to Diff 5594.Jul 1 2019, 3:31 PM

use variable instead of ternary

swh-public-ci added a comment.Jul 1 2019, 3:45 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/522/ for more details.

Harbormaster completed remote builds in B6602: Diff 5594.Jul 1 2019, 3:45 PM
vlorentz updated this revision to Diff 5604.Jul 1 2019, 3:52 PM

rebase

This revision was landed with ongoing or failed builds.Jul 1 2019, 3:52 PM
Closed by commit rDSTOd98f0658c179: Make all endpoints support origin urls instead of ids. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B6612: Diff 5604!Jul 1 2019, 4:11 PM
swh-public-ci added a comment.Jul 1 2019, 4:11 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/528/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/528/console

Revision Contents
Changeset List

PathSize
swh/
storage/
32 lines
34 lines
tests/
339 lines

Diff 5604

View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal