Add origin_visit counter to the in-mem storage + Add test for snapshot/release counters.
ClosedPublic
Actions

Authored by vlorentz on Jun 5 2019, 11:41 AM.

Details

Reviewers

Group Reviewers

Commits

rDSTOCdc7c1e0ad049: Add test for snapshot/release counters.
rDSTOCaec95716fc42: Add origin_visit counter to the in-mem storage.
rDSTOdc7c1e0ad049: Add test for snapshot/release counters.
rDSTOaec95716fc42: Add origin_visit counter to the in-mem storage.

Diff Detail

Repository

rDSTO Storage manager

Branch

counter-origin_visit

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6249
Build 8642: tox-on-jenkins	Jenkins
Build 8641: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 5 2019, 11:41 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 5 2019, 11:41 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/437/ for more details.

Harbormaster completed remote builds in B6019: Diff 5072.Jun 5 2019, 11:53 AM

Add test for snapshot/release counters.

vlorentz retitled this revision from Add origin_visit counter to the in-mem storage. to Add origin_visit counter to the in-mem storage + Add test for snapshot/release counters..Jun 5 2019, 1:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/439/ for more details.

Harbormaster completed remote builds in B6025: Diff 5078.Jun 5 2019, 1:28 PM

Ok, but I would have loved to see a word or 2 explaining why this revision is needed in the commit message.

This revision is now accepted and ready to land.Jun 12 2019, 12:16 PM

It's "needed" to add the test. Adding it to the in-mem storage is a side-effect

rebase

This revision was landed with ongoing or failed builds.Jun 17 2019, 11:01 AM

Closed by commit rDSTOaec95716fc42: Add origin_visit counter to the in-mem storage. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B6249: Diff 5272!Jun 17 2019, 11:01 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/496/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/496/console

Revision Contents
Changeset List

Path

Size

swh/

storage/

in_memory.py

7 lines

tests/

test_storage.py

6 lines

Diff 5272

View Options

swh/storage/in_memory.py