Add tests for webapp functionalities - sidebar, back-to-top
Related T1768
Details
Details
- Reviewers
vlorentz anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPS1d7bafd83d50: Add tests for back-to-top and sidebar
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- webappTest
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6204 Build 8561: tox-on-jenkins Build 8560: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/487/ for more details.
Comment Actions
Nice! Could you also add a test checking the width of the collapsed sidebar is lower than of the open sidebar?
Comment Actions
While working on the tests, I found that for non-lg devices (width<992), first time you press the push-menu, it doesn't toggle. Instead it adds 'sidebar-collapse' first time. I think there is some conflict between webapp-utils.js:5 and the bootstrap defaults. I couldn't find the exact cause to it.
Comment Actions
In that case should I move back-to-top tests to another file or keep it in the same sidebar.spec.js ?
Comment Actions
Nice! I agree with @vlorentz , you should split the tests into two spec files: sidebar.spec.js and back-to-top.spec.js. Once it is done, that diff can be landed.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/495/ for more details.
Comment Actions
Sidebar tests fail.
This is because, the cypress view is interpreted as sm by JS.
Cypress viewport is 1000px(width) by 660px(height). Apparently the window width is a bit smaller than the viewport. (around 985px)
I am updating the cypress config file (1920*1080) to ensure we are testing for lg devices by default.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/497/ for more details.