- Set width of metadata popover to 100% in mobiles (xs screens)
Related T1786
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPSd355d8973205: Improve metadata popover on xs screens Related T1786
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- metadataPopover
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6092 Build 8391: tox-on-jenkins Jenkins Build 8390: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/472/ for more details.
Comment Actions
Just a couple of nitpicks for small screens (see screenshot below):
- Can you slightly move the popover to the right in order to see its borders ?
- The Permalinks button should not overlap the popover
| swh/web/assets/src/bundles/browse/browse-utils.js | ||
|---|---|---|
| 26 | I think you can increase that threshold to 992 (next responsive breakpoint). For a screen with a width of 800px, the popover will look better if it is anchored to the top, see screenshot below:  | |
| swh/web/assets/src/bundles/browse/browse.css | ||
| 83 | Can you keep this rule for large screen ? Sometimes some metadata associated to the objects in the archive contains text with really long lines and the popover gets oversized because of that. | |
| swh/web/assets/src/bundles/browse/browse-utils.js | ||
|---|---|---|
| 26 | At 800px, it looks fine originally.  | |
| swh/web/assets/src/bundles/browse/browse-utils.js | ||
|---|---|---|
| 26 | I think that in my example, the popover got oversized due to its content (long lines in a metadata field surely). If you reinstate the max-width css rule for screens width greater than 768 pixels, this should be OK for all metadata. | |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/473/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/475/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/476/ for more details.