Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDSTOC334978897a83: Make origin_visit_upsert parse date strings.
rDSTO334978897a83: Make origin_visit_upsert parse date strings.
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- upsert_parse_date
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6041 Build 8310: tox-on-jenkins Jenkins Build 8309: arc lint + arc unit
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/435/ for more details.
| swh/storage/tests/test_storage.py | ||
|---|---|---|
| 1677 | for this kind of test, I prefer to be able to read the input data litterally. Otherwise the reader need to pay way much more attention to get what self.date_visit is (what type) and pay extra attention to the presence of the str() call. It's much easier to read as: 'date': '2019-01-15 10 15:35:27 CET' | |
| swh/storage/tests/test_storage.py | ||
|---|---|---|
| 1677 | What if I add a comment instead? | |
| swh/storage/tests/test_storage.py | ||
|---|---|---|
| 1677 | I prefer a literal string, but I would accept your diff with a comment. As you prefer. | |
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/450/ for more details.
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/451/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/451/console