Differential D1218

Prevent deadlocks by always updating items in the same order.
ClosedPublic
Actions

Authored by vlorentz on Mar 4 2019, 12:49 PM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Commits

rDCIDX199da66d78df: Prevent deadlocks by always updating items in the same order.

Test Plan

The tests are a bit fragile since they are testing a concurrency
issue.
But when running them without the fix, there is almost always
at least one failure on my machine (with pgsql running on a tmpfs).

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

update-deadlock

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4527
Build 6011: tox-on-jenkins	Jenkins
Build 6010: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 4 2019, 12:49 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 4 2019, 12:49 PM

vlorentz mentioned this in T1549: Clean up entries in {origin_intrinsic,revision}_metadata with no metadata.Mar 4 2019, 12:51 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/482/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/482/console

Harbormaster failed remote builds in B4526: Diff 3826!Mar 4 2019, 12:53 PM

fix test on http api

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/484/ for more details.

Harbormaster completed remote builds in B4527: Diff 3827.Mar 4 2019, 12:58 PM

zack accepted this revision.Mar 4 2019, 3:10 PM

This revision is now accepted and ready to land.Mar 4 2019, 3:10 PM

Closed by commit rDCIDX199da66d78df: Prevent deadlocks by always updating items in the same order. (authored by vlorentz). · Explain WhyMar 5 2019, 9:48 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

indexer/

storage/

__init__.py

7 lines

tests/

storage/

test_storage.py

208 lines

Diff 3827

View Options

swh/indexer/storage/init.py

View Options

swh/indexer/tests/storage/test_storage.py

Prevent deadlocks by always updating items in the same order.ClosedPublicActions