Page MenuHomeSoftware Heritage
Differential D103

Fix leftover issues from T431
ClosedPublic
Actions

Authored by jbertran on Aug 19 2016, 3:39 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
R65:584302ffbbce: feedback from D103 - insert function origin URL
R65:08ea8d7cd82f: views: remove dead flaskAPI utilities usage
R65:a85bb62ecb65: renderers: better docstring trimming
R65:808aa6bccc34: apidoc: remove stray dead code
R65:fe7f5e6495f2: templates: fix html issues, api/doc reST to HTML
R65:556a45c1190f: debian/control: drop flaskAPI, add docutils
rDWAPPS584302ffbbce: feedback from D103 - insert function origin URL
rDWAPPS08ea8d7cd82f: views: remove dead flaskAPI utilities usage
rDWAPPS808aa6bccc34: apidoc: remove stray dead code
rDWAPPSfe7f5e6495f2: templates: fix html issues, api/doc reST to HTML
rDWAPPSa85bb62ecb65: renderers: better docstring trimming
rDWAPPS556a45c1190f: debian/control: drop flaskAPI, add docutils
Summary

debian/control: drop flaskAPI, add docutils
renderers: better docstring trimming
templates: fix html issues, api/doc reST to HTML
apidoc: remove stray dead code

Diff Detail

Repository
rDWAPPS Web applications
Branch
WorkingBranch
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 396
Build 586: Software Heritage Python tests
Build 585: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 350.Aug 19 2016, 3:39 PM
jbertran retitled this revision from to Fix leftover issues from T431.
jbertran updated this object.
jbertran edited the test plan for this revision. (Show Details)
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 19 2016, 3:39 PM
ardumont added a subscriber: ardumont.Aug 19 2016, 4:02 PM
ardumont added inline comments.
swh/web/ui/renderers.py
141

To avoid looking for it https://www.python.org/dev/peps/pep-0257/#handling-docstring-indentation
Maybe a good idea to add the link directly in the docstring?

ardumont accepted this revision.Aug 19 2016, 4:05 PM
ardumont added a reviewer: ardumont.
This revision is now accepted and ready to land.Aug 19 2016, 4:05 PM
jbertran updated this revision to Diff 351.Aug 19 2016, 4:09 PM
jbertran edited edge metadata.
  • views: remove dead flaskAPI utilities usage
  • feedback from D103 - insert function origin URL
This revision now requires review to proceed.Aug 19 2016, 4:09 PM
ardumont accepted this revision.Aug 19 2016, 4:12 PM
ardumont edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2016, 4:12 PM
Closed by commit rDWAPPS556a45c1190f: debian/control: drop flaskAPI, add docutils (authored by jbertran). · Explain WhyAug 19 2016, 4:16 PM
This revision was automatically updated to reflect the committed changes.
jbertran mentioned this in rDWAPPS584302ffbbce: feedback from D103 - insert function origin URL.
olasd added a subscriber: olasd.Aug 19 2016, 6:10 PM

Your trim function is in the python stdlib as https://docs.python.org/3/library/inspect.html#inspect.cleandoc

jbertran mentioned this in R65:584302ffbbce: feedback from D103 - insert function origin URL.Feb 23 2019, 1:55 AM

Revision Contents
Changeset List

PathSize
debian/
2 lines
swh/
web/
ui/
9 lines
33 lines
templates/
2 lines
2 lines
tests/
6 lines
views/
23 lines
4 lines

Diff 351

View Options

debian/control

Loading...
View Options

swh/web/ui/apidoc.py

Loading...
View Options

swh/web/ui/renderers.py

Loading...
View Options

swh/web/ui/templates/api.html

Loading...
View Options

swh/web/ui/templates/apidoc.html

Loading...
View Options

swh/web/ui/tests/test_renderers.py

Loading...
View Options

swh/web/ui/views/browse.py

Loading...
View Options

swh/web/ui/views/main.py

Loading...
About · Developer information · Legal