Page MenuHomeSoftware Heritage
Differential D8704

[WIP] Move targets to separate objects with type and identifier
Needs ReviewPublic
Actions

Authored by jayeshv on Oct 18 2022, 2:55 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Maniphest Tasks
T4518: GraphQL: Handle missing reference object errors
Summary

Add an extra indirection while serving target objects.
This will provide the client with an option to get the target identifier
even when the requested object is missing from the archive.
This will also provide an extra grouping for target object fields.

Related to T4518

Diff Detail

Repository
rDGQL GraphQL API
Branch
target-obj-D8704
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33331
Build 52244: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 52243: arc lint + arc unit

Event Timeline

jayeshv created this revision.Oct 18 2022, 2:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2022, 2:55 PM
swh-public-ci added a comment.Oct 18 2022, 2:57 PM

Build is green

Patch application report for D8704 (id=31420)

Rebasing onto c6d410118d...

Current branch diff-target is up to date.
Changes applied before test
commit b22e8197bc67560bba8be7df845339b7213ee08e
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/218/ for more details.

Harbormaster completed remote builds in B32365: Diff 31420.Oct 18 2022, 2:57 PM
jayeshv requested review of this revision.Oct 18 2022, 2:57 PM
jayeshv updated this revision to Diff 31426.Oct 18 2022, 4:06 PM

more docs

swh-public-ci added a comment.Oct 18 2022, 4:08 PM

Build is green

Patch application report for D8704 (id=31426)

Rebasing onto c6d410118d...

Current branch diff-target is up to date.
Changes applied before test
commit a7bc6639bbf9efe679d79cfb15fe8c3a9e5b80c3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/219/ for more details.

Harbormaster completed remote builds in B32371: Diff 31426.Oct 18 2022, 4:08 PM
jayeshv updated this revision to Diff 31428.Oct 18 2022, 4:49 PM

type checks

swh-public-ci added a comment.Oct 18 2022, 4:52 PM

Build has FAILED

Patch application report for D8704 (id=31428)

Rebasing onto c6d410118d...

Current branch diff-target is up to date.
Changes applied before test
commit 700c19c11460a6fff4100f93aae525288a0d31c7
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

Link to build: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/220/
See console output for more information: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/220/console

Harbormaster failed remote builds in B32373: Diff 31428!Oct 18 2022, 4:52 PM
jayeshv updated this revision to Diff 31429.Oct 18 2022, 4:59 PM

remove commented code

swh-public-ci added a comment.Oct 18 2022, 5:02 PM

Build has FAILED

Patch application report for D8704 (id=31429)

Rebasing onto c6d410118d...

Current branch diff-target is up to date.
Changes applied before test
commit 67b58598fb6bb450aa7bdf97ec26242a89bf9288
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

Link to build: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/221/
See console output for more information: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/221/console

Harbormaster failed remote builds in B32374: Diff 31429!Oct 18 2022, 5:02 PM
jayeshv updated this revision to Diff 31572.Oct 24 2022, 4:00 PM

Use a generic identifier

swh-public-ci added a comment.Oct 24 2022, 4:03 PM

Build has FAILED

Patch application report for D8704 (id=31572)

Rebasing onto 7522a848fa...

Current branch diff-target is up to date.
Changes applied before test
commit 68f166e59ad8b9a3a29ad17d24c68a9cfd551ee4
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

Link to build: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/224/
See console output for more information: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/224/console

Harbormaster failed remote builds in B32526: Diff 31572!Oct 24 2022, 4:03 PM
jayeshv updated this revision to Diff 32246.Dec 9 2022, 9:26 AM

rebase and experimetal features

swh-public-ci added a comment.Dec 9 2022, 9:28 AM

Build has FAILED

Patch application report for D8704 (id=32246)

Rebasing onto c28b65feaf...

Current branch diff-target is up to date.
Changes applied before test
commit 350c3d7b5fd63a8f44ad7d0fa8931a372ca041ce
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

Link to build: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/247/
See console output for more information: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/247/console

Harbormaster failed remote builds in B33201: Diff 32246!Dec 9 2022, 9:28 AM
jayeshv updated this revision to Diff 32247.Dec 9 2022, 9:34 AM

bug fix

swh-public-ci added a comment.Dec 9 2022, 9:36 AM

Build is green

Patch application report for D8704 (id=32247)

Rebasing onto c28b65feaf...

Current branch diff-target is up to date.
Changes applied before test
commit 8c68fbf6db41cbfb3755289028e403f83315001f
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/248/ for more details.

Harbormaster completed remote builds in B33202: Diff 32247.Dec 9 2022, 9:36 AM
jayeshv updated this revision to Diff 32335.Dec 21 2022, 9:37 AM

rebase

swh-public-ci added a comment.Dec 21 2022, 9:39 AM

Build is green

Patch application report for D8704 (id=32335)

Rebasing onto c8bc6947fa...

First, rewinding head to replay your work on top of it...
Applying: Move targets to separate objects with type and identifier
Changes applied before test
commit f8341b61a364c10d14651dc287b0d00b0e84ab05
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/258/ for more details.

Harbormaster completed remote builds in B33326: Diff 32335.Dec 21 2022, 9:39 AM
jayeshv updated this revision to Diff 32344.Dec 21 2022, 2:59 PM

add missing tests

swh-public-ci added a comment.Dec 21 2022, 3:02 PM

Build is green

Patch application report for D8704 (id=32344)

Rebasing onto 5446d4f87f...

Current branch diff-target is up to date.
Changes applied before test
commit f1b8cfbb8d5ade4b0a8aeee92517ad9b2fec6659
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/262/ for more details.

Harbormaster completed remote builds in B33331: Diff 32344.Dec 21 2022, 3:02 PM
jayeshv updated this revision to Diff 32373.Dec 26 2022, 5:24 PM

rebase

swh-public-ci added a comment.Dec 26 2022, 5:26 PM

Build is green

Patch application report for D8704 (id=32373)

Rebasing onto f6b5a2d5e5...

Current branch diff-target is up to date.
Changes applied before test
commit 799b18936edd1d0f991cbc5030c287b431c2b46e
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/275/ for more details.

Harbormaster completed remote builds in B33359: Diff 32373.Dec 26 2022, 5:26 PM
jayeshv updated this revision to Diff 32375.Dec 28 2022, 3:36 PM

remove unused SWHID reference

swh-public-ci added a comment.Dec 28 2022, 3:39 PM

Build is green

Patch application report for D8704 (id=32375)

Rebasing onto f6b5a2d5e5...

Current branch diff-target is up to date.
Changes applied before test
commit 99d6895b7262903b5a86825d89260f58cdc3f872
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/277/ for more details.

Harbormaster completed remote builds in B33361: Diff 32375.Dec 28 2022, 3:39 PM
jayeshv added a task: T4518: GraphQL: Handle missing reference object errors.Dec 28 2022, 3:55 PM
jayeshv updated this revision to Diff 32418.Jan 3 2023, 11:55 AM

rebase

swh-public-ci added a comment.Jan 3 2023, 11:57 AM

Build is green

Patch application report for D8704 (id=32418)

Rebasing onto f2fae75b9c...

Current branch diff-target is up to date.
Changes applied before test
commit 6d2a8c3b70b8d74c396f018ff18442d3326a4279
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/286/ for more details.

Harbormaster completed remote builds in B33395: Diff 32418.Jan 3 2023, 11:57 AM
jayeshv updated this revision to Diff 32422.Jan 3 2023, 2:39 PM

change searchresult to use the target object

swh-public-ci added a comment.Jan 3 2023, 2:41 PM

Build is green

Patch application report for D8704 (id=32422)

Rebasing onto f2fae75b9c...

Current branch diff-target is up to date.
Changes applied before test
commit acf50f29277686d447fe6b122f6e05fbdaad9591
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/287/ for more details.

Harbormaster completed remote builds in B33399: Diff 32422.Jan 3 2023, 2:41 PM
jayeshv updated this revision to Diff 32425.Jan 3 2023, 3:15 PM

Use new target hierarchy for snapshot branch target

swh-public-ci added a comment.Jan 3 2023, 3:17 PM

Build is green

Patch application report for D8704 (id=32425)

Rebasing onto f2fae75b9c...

Current branch diff-target is up to date.
Changes applied before test
commit 543ac849008d473773de8b5f24dd6c95165e1f0a
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/288/ for more details.

Harbormaster completed remote builds in B33401: Diff 32425.Jan 3 2023, 3:17 PM
jayeshv updated this revision to Diff 32428.Jan 3 2023, 4:54 PM

mising types and docs

jayeshv edited the summary of this revision. (Show Details)Jan 3 2023, 4:55 PM
swh-public-ci added a comment.Jan 3 2023, 4:56 PM

Build has FAILED

Patch application report for D8704 (id=32428)

Rebasing onto f2fae75b9c...

Current branch diff-target is up to date.
Changes applied before test
commit bb1474c9a5ceedd429b942eb685eb26060e2ccc9
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.
    Targets in SnapshotBranch, Release, DirectoryEntry and SearchResult
    are moved to the new structure.
    
    Related to T4518

Link to build: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/289/
See console output for more information: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/289/console

Harbormaster failed remote builds in B33404: Diff 32428!Jan 3 2023, 4:56 PM
jayeshv updated this revision to Diff 32429.Jan 3 2023, 5:15 PM

cleanup

swh-public-ci added a comment.Jan 3 2023, 5:17 PM

Build has FAILED

Patch application report for D8704 (id=32429)

Rebasing onto f2fae75b9c...

Current branch diff-target is up to date.
Changes applied before test
commit 3ea0f9a115bf3d515a2ebc5e88d75a6bb8e06362
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.
    Targets in SnapshotBranch, Release, DirectoryEntry and SearchResult
    are moved to the new structure.
    
    Related to T4518

Link to build: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/290/
See console output for more information: https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/290/console

Harbormaster failed remote builds in B33405: Diff 32429!Jan 3 2023, 5:17 PM
jayeshv updated this revision to Diff 32430.Jan 3 2023, 5:24 PM

doc fix

swh-public-ci added a comment.Jan 3 2023, 5:26 PM

Build is green

Patch application report for D8704 (id=32430)

Rebasing onto f2fae75b9c...

Current branch diff-target is up to date.
Changes applied before test
commit 91683c5dc85c25ef9e51e3f9e770c72e5c6e95d2
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.
    Targets in SnapshotBranch, Release, DirectoryEntry and SearchResult
    are moved to the new structure.
    
    Related to T4518

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/291/ for more details.

Harbormaster completed remote builds in B33406: Diff 32430.Jan 3 2023, 5:26 PM
jayeshv updated this revision to Diff 32437.Jan 4 2023, 12:28 PM

cleanup

swh-public-ci added a comment.Jan 4 2023, 12:30 PM

Build is green

Patch application report for D8704 (id=32437)

Rebasing onto f2fae75b9c...

Current branch diff-target is up to date.
Changes applied before test
commit 06d290abcc6c596b6200b41841df67dc82cdef64
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Oct 18 11:32:27 2022 +0200

    Move targets to separate objects with type and identifier
    
    Add an extra indirection while serving target objects.
    This will provide the client with an option to get the target identifier
    even when the requested object is missing from the archive.
    This will also provide an extra grouping for target object fields.
    Targets in SnapshotBranch, Release, DirectoryEntry and SearchResult
    are moved to the new structure.
    
    Related to T4518

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/294/ for more details.

Harbormaster completed remote builds in B33412: Diff 32437.Jan 4 2023, 12:30 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
graphql/
5 lines100%
Loading...
resolvers/
15 lines100%
Loading...
15 lines100%
Loading...
4 lines100%
Loading...
14 lines100%
Loading...
14 lines100%
Loading...
62 lines100%
Loading...
17 lines100%
Loading...
2 lines100%
Loading...
2 lines100%
Loading...
8 lines94%
Loading...
39 lines88%
Loading...
schema/
98 lines--
tests/
functional/
19 lines100%
Loading...
8 lines100%
Loading...
54 lines100%
Loading...
89 lines100%
Loading...
unit/
resolvers/
52 lines100%
Loading...

Diff 32344

View Options

swh/graphql/app.py

Loading...
View Options

swh/graphql/resolvers/content.py

Loading...
View Options

swh/graphql/resolvers/directory.py

Loading...
View Options

swh/graphql/resolvers/directory_entry.py

Loading...
View Options

swh/graphql/resolvers/release.py

Loading...
View Options

swh/graphql/resolvers/resolver_factory.py

Loading...
View Options

swh/graphql/resolvers/resolvers.py

Loading...
View Options

swh/graphql/resolvers/revision.py

Loading...
View Options

swh/graphql/resolvers/search.py

Loading...
View Options

swh/graphql/resolvers/snapshot.py

Loading...
View Options

swh/graphql/resolvers/snapshot_branch.py

Loading...
View Options

swh/graphql/resolvers/target.py

Loading...
View Options

swh/graphql/schema/schema.graphql

Loading...
View Options

swh/graphql/tests/functional/test_content.py

Loading...
View Options

swh/graphql/tests/functional/test_directory.py

Loading...
View Options

swh/graphql/tests/functional/test_directory_entry.py

Loading...
View Options

swh/graphql/tests/functional/test_release_node.py

Loading...
View Options

swh/graphql/tests/unit/resolvers/test_resolvers.py

Loading...
About · Developer information · Legal